From: Jan Kiszka <jan.kiszka@siemens.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Tokarev <mjt@tls.msk.ru>,
Anthony Liguori <aliguori@us.ibm.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: [PATCH] compat: Fix RT signal mask corruption via sigprocmask
Date: Wed, 09 May 2012 19:09:59 -0300 [thread overview]
Message-ID: <4FAAEB37.1080001@siemens.com> (raw)
compat_sys_sigprocmask reads a smaller signal mask from userspace than
sigprogmask accepts for setting. So the high word of blocked.sig[0] will
be cleared, releasing any potentially blocked RT signal.
This was discovered via userspace code that relies on get/setcontext.
glibc's i386 versions of those functions use sigprogmask instead of
rt_sigprogmask to save/restore the signal mask and caused RT signal
unblocking this way.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
kernel/compat.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/compat.c b/kernel/compat.c
index 74ff849..03e491d 100644
--- a/kernel/compat.c
+++ b/kernel/compat.c
@@ -381,6 +381,8 @@ asmlinkage long compat_sys_sigprocmask(int how, compat_old_sigset_t __user *set,
if (set && get_user(s, set))
return -EFAULT;
+ s |= current->blocked.sig[0] &
+ ~((old_sigset_t)(compat_old_sigset_t)-1);
old_fs = get_fs();
set_fs(KERNEL_DS);
ret = sys_sigprocmask(how,
--
1.7.3.4
next reply other threads:[~2012-05-09 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:09 Jan Kiszka [this message]
2012-05-09 22:09 ` [PATCH] compat: Fix RT signal mask corruption via sigprocmask Jan Kiszka
2012-05-10 0:00 ` Linus Torvalds
2012-05-10 13:04 ` [PATCH v2] " Jan Kiszka
2012-05-10 13:04 ` Jan Kiszka
2012-05-10 15:44 ` Linus Torvalds
2012-05-10 15:58 ` Linus Torvalds
2012-05-10 17:38 ` Jan Kiszka
2012-05-10 18:51 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAAEB37.1080001@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=akpm@linux-foundation.org \
--cc=aliguori@us.ibm.com \
--cc=hpa@zytor.com \
--cc=kwolf@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mjt@tls.msk.ru \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox