From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Subject: Re: [PATCH v2] compat: Fix RT signal mask corruption via sigprocmask Date: Thu, 10 May 2012 22:51:53 +0400 Message-ID: <4FAC0E49.6050004@msgid.tls.msk.ru> References: <4FAAEB37.1080001@siemens.com> <4FABBCE4.3050503@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from isrv.corpit.ru ([86.62.121.231]:45608 "EHLO isrv.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760473Ab2EJSv4 (ORCPT ); Thu, 10 May 2012 14:51:56 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Jan Kiszka , Linux Kernel Mailing List , "linux-arch@vger.kernel.org" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Anthony Liguori , Kevin Wolf On 10.05.2012 19:58, Linus Torvalds wrote: > On Thu, May 10, 2012 at 8:44 AM, Linus Torvalds > wrote: >> >> I think I'll just edit your patch directly, no need to send me a new version. > > Ok, just FYI, this is the incremental diff I ended up with. I'll > commit it as this, but I'm sending it out for people to verify before > I do. Although just from looking at the code generation, it really > does just change those four instructions that do a mask to a single > 'movl', so I think it's pretty safe even though I haven't tested it. I tested the changes (from Jan and Linus's patches) and the result a) looks sane, and b) actually works and fixes our long-standing issues. So you can add my Tested-By: Michael Tokarev or, if you prefer, Signed-off-By: Michael Tokarev for the combined patch. Thank you for the excellent catch Jan! /mjt