From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64_ds Date: Fri, 18 May 2012 14:41:11 -0700 Message-ID: <4FB6C1F7.1010307@zytor.com> References: <1337292816-10839-1-git-send-email-hjl.tools@gmail.com> <201205182131.29353.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:47915 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968043Ab2ERVli (ORCPT ); Fri, 18 May 2012 17:41:38 -0400 In-Reply-To: <201205182131.29353.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Linus Torvalds , David Daney , Ralf Baechle , "H.J. Lu" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de On 05/18/2012 02:31 PM, Arnd Bergmann wrote: > > However, in the kernel we *always* copy the fields one by one for compat > mode, even for the architectures that have identical layout between 32 and > 64 bit, and at least one libc implementation that I've seen (IIRC uClibc) > hardcodes the data structure to be the same as x86, with the padding > after the 'long', for all architectures. When I introduced the asm-generic > version of this, we had a discussion about whether we should try to use > the version with the "correct" padding but in the end decided to just use > the x86 version because that is what most big-endian architectures do > anyway. > Ouch. Fail. asm-generic should be about what is the right thing going forward. -hpa