From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clemens Ladisch Subject: Re: [PATCH] common: dma-mapping: add support for generic dma_mmap_* calls Date: Fri, 29 Jun 2012 15:16:54 +0200 Message-ID: <4FEDAAC6.2050202@ladisch.de> References: <1339741135-7841-1-git-send-email-m.szyprowski@samsung.com> <4FED8D03.10507@ladisch.de> <00a501cd55f7$323946f0$96abd4d0$%szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51669 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753861Ab2F2NQ6 (ORCPT ); Fri, 29 Jun 2012 09:16:58 -0400 In-Reply-To: <00a501cd55f7$323946f0$96abd4d0$%szyprowski@samsung.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, 'Kyungmin Park' , 'Arnd Bergmann' , 'Russell King - ARM Linux' , 'Benjamin Herrenschmidt' , 'Konrad Rzeszutek Wilk' , 'David Gibson' , 'Subash Patel' , 'Sumit Semwal' Marek Szyprowski wrote: > On Friday, June 29, 2012 1:10 PM Clemens Ladisch wrote: >> Marek Szyprowski wrote: >>> +++ b/drivers/base/dma-mapping.c >>> ... >>> +int dma_common_mmap(struct device *dev, struct vm_area_struct *vma, >>> + void *cpu_addr, dma_addr_t dma_addr, size_t size) >>> +{ >>> + int ret = -ENXIO; >>> + ... >>> + if (dma_mmap_from_coherent(dev, vma, cpu_addr, size, &ret)) >>> + return ret; >> >> This will return -ENXIO if dma_mmap_from_coherent() succeeds. > > Thanks for spotting this! Sorry, I was wrong; ret is actually set by dma_mmap_from_coherent's output parameter. (That function's documentation appears to be incomplete.) Regards, Clemens