linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arch@vger.kernel.org
Subject: ia64 broken by transparent huge pages - other arches too?
Date: Fri, 14 Jan 2011 09:50:45 -0800	[thread overview]
Message-ID: <4d308cf5394566ccc@agluck-desktop.sc.intel.com> (raw)

Didn't Andrew make some rash promise at kernel summit about stopping
eating if "-mm" wasn't included in linux-next by the end of November?

Must be getting pretty hungry by now.

The transparent huge page code just arrived in the merge window
without having been in linux-next.  I see this error when trying
to build for ia64 from Linus' tree this morning:

In file included from /home/aegl/generic-smp/arch/ia64/include/asm/pgtable.h:611,
                 from include/linux/mm.h:41,
                 from /home/aegl/generic-smp/arch/ia64/include/asm/uaccess.h:39,
                 from include/linux/poll.h:14,
                 from include/linux/rtc.h:117,
                 from include/linux/efi.h:19,
                 from /home/aegl/generic-smp/arch/ia64/include/asm/sal.h:40,
                 from /home/aegl/generic-smp/arch/ia64/include/asm/mca.h:20,
                 from arch/ia64/kernel/asm-offsets.c:17:
include/asm-generic/pgtable.h: In function ‘pmdp_get_and_clear’:
include/asm-generic/pgtable.h:96: error: implicit declaration of function ‘__pmd’
include/asm-generic/pgtable.h:96: error: incompatible types in return
make[1]: *** [arch/ia64/kernel/asm-offsets.s] Error 1


Looks like arch/*/include/pgtable.h needs to define __pmd() but only x86
was blessed with it.

-Tony

WARNING: multiple messages have this Message-ID (diff)
From: "Luck, Tony" <tony.luck@intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arch@vger.kernel.org
Subject: ia64 broken by transparent huge pages - other arches too?
Date: Fri, 14 Jan 2011 09:50:45 -0800	[thread overview]
Message-ID: <4d308cf5394566ccc@agluck-desktop.sc.intel.com> (raw)
Message-ID: <20110114175045.Pix61YImbSPfyDZzYqvc5PiNLhwYdFCvQjfSBZ45qN8@z> (raw)

Didn't Andrew make some rash promise at kernel summit about stopping
eating if "-mm" wasn't included in linux-next by the end of November?

Must be getting pretty hungry by now.

The transparent huge page code just arrived in the merge window
without having been in linux-next.  I see this error when trying
to build for ia64 from Linus' tree this morning:

In file included from /home/aegl/generic-smp/arch/ia64/include/asm/pgtable.h:611,
                 from include/linux/mm.h:41,
                 from /home/aegl/generic-smp/arch/ia64/include/asm/uaccess.h:39,
                 from include/linux/poll.h:14,
                 from include/linux/rtc.h:117,
                 from include/linux/efi.h:19,
                 from /home/aegl/generic-smp/arch/ia64/include/asm/sal.h:40,
                 from /home/aegl/generic-smp/arch/ia64/include/asm/mca.h:20,
                 from arch/ia64/kernel/asm-offsets.c:17:
include/asm-generic/pgtable.h: In function ‘pmdp_get_and_clear’:
include/asm-generic/pgtable.h:96: error: implicit declaration of function ‘__pmd’
include/asm-generic/pgtable.h:96: error: incompatible types in return
make[1]: *** [arch/ia64/kernel/asm-offsets.s] Error 1


Looks like arch/*/include/pgtable.h needs to define __pmd() but only x86
was blessed with it.

-Tony

             reply	other threads:[~2011-01-14 17:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 17:50 Luck, Tony [this message]
2011-01-14 17:50 ` ia64 broken by transparent huge pages - other arches too? Luck, Tony
2011-01-14 18:30 ` Andrea Arcangeli
2011-01-14 18:50   ` Tony Luck
2011-01-14 19:03     ` Andrea Arcangeli
2011-01-15  7:21 ` Benjamin Herrenschmidt
2011-01-15 15:59   ` Andrea Arcangeli
2011-01-15 16:47     ` James Bottomley
2011-01-15 17:23       ` Andrea Arcangeli
2011-01-15 19:02         ` Geert Uytterhoeven
2011-01-15 21:31         ` Benjamin Herrenschmidt
2011-01-16 21:05   ` Linus Torvalds
2011-01-16 21:10     ` Andrew Morton
2011-01-16 22:06       ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d308cf5394566ccc@agluck-desktop.sc.intel.com \
    --to=tony.luck@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).