From: "Li Zhe" <lizhe.67@bytedance.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: <apopple@nvidia.com>, <arnd@arndb.de>, <balbirs@nvidia.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>,
<david@kernel.org>, <kees@kernel.org>, <mingo@redhat.com>,
<muchun.song@linux.dev>, <rppt@kernel.org>, <tglx@kernel.org>,
<linux-arch@vger.kernel.org>, <linux-hardening@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<x86@kernel.org>
Subject: Re: [PATCH v8 0/9] mm: optimize zone-device memmap initialization
Date: Tue, 28 Jul 2026 14:18:44 +0800 [thread overview]
Message-ID: <4d71dc0f-dce0-4d69-80ca-bdd8047eb9da@bytedance.com> (raw)
In-Reply-To: <20260727135725.694139f5ecad67752b0985d0@linux-foundation.org>
On 7/28/26 4:57 AM, Andrew Morton wrote:
> On Mon, 27 Jul 2026 20:34:20 +0800 "Li Zhe" <lizhe.67@bytedance.com> wrote:
>
>> memmap_init_zone_device() can take a noticeable amount of time when large
>> pmem namespaces are bound or rebound, because it initializes nearly
>> identical struct page descriptors one PFN at a time. This series reduces
>> that ZONE_DEVICE memmap initialization overhead by reusing prepared
>> struct page templates and, on x86, using memcpy_nontemporal() for the
>> template copy path.
> Thanks.
>
> Human review started out strong but petered out later in the series.
> This often happens. I'd prefer to wait until it fills out further.
>
> AI review had things to say, as it often does:
> https://sashiko.dev/#/patchset/20260727123429.5673-1-lizhe.67@bytedance.com
Thanks for the review.
These comments seem to mostly cover the same memcpy_nontemporal(),
MOVNTI alignment, helper-level drain, and sanitizer/tracepoint tradeoff
topics that were discussed for v7.
The v8 changes keep the x86 non-temporal copy path unchanged, except for
making the generic memcpy_nontemporal() fallback a void function-like
macro. The remaining updates are clarifications in the cover letter and
commit messages.
So I do not plan further code changes for these comments at this point,
unless someone points out a problem in the previous discussion.
For the previous discussion, please see:
https://lore.kernel.org/all/20260722081800.90085-1-lizhe.67@bytedance.com/
Thanks,
Zhe
prev parent reply other threads:[~2026-07-28 6:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 12:34 [PATCH v8 0/9] mm: optimize zone-device memmap initialization Li Zhe
2026-07-27 12:34 ` [PATCH v8 1/9] mm: fix stale ZONE_DEVICE refcount comment Li Zhe
2026-07-27 12:34 ` [PATCH v8 2/9] mm: factor zone-device page init helpers out of __init_zone_device_page Li Zhe
2026-07-27 12:34 ` [PATCH v8 3/9] mm: add a set_page_section_from_pfn() helper Li Zhe
2026-07-27 12:34 ` [PATCH v8 4/9] mm: add a template-based fast path for zone-device page init Li Zhe
2026-07-27 12:34 ` [PATCH v8 5/9] mm: extend the template fast path to zone-device compound tails Li Zhe
2026-07-27 12:34 ` [PATCH v8 6/9] string: introduce memcpy_nontemporal() Li Zhe
2026-07-27 12:34 ` [PATCH v8 7/9] x86/string: extend memcpy_flushcache() fixed-size fastpaths Li Zhe
2026-07-29 23:48 ` Borislav Petkov
2026-07-30 8:05 ` Li Zhe
2026-07-30 8:14 ` David Laight
2026-07-27 12:34 ` [PATCH v8 8/9] mm: use memcpy_nontemporal() in zone-device template copies Li Zhe
2026-07-27 12:34 ` [PATCH v8 9/9] mm: always use the zone-device template init path Li Zhe
2026-07-27 20:57 ` [PATCH v8 0/9] mm: optimize zone-device memmap initialization Andrew Morton
2026-07-28 6:18 ` Li Zhe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d71dc0f-dce0-4d69-80ca-bdd8047eb9da@bytedance.com \
--to=lizhe.67@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=arnd@arndb.de \
--cc=balbirs@nvidia.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=kees@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox