From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Zigotzky Subject: Re: use generic DMA mapping code in powerpc V4 Date: Sun, 10 Feb 2019 13:00:20 +0100 Message-ID: <4e7137db-e600-0d20-6fb2-6d0f9739aca3@xenosoft.de> References: <9632DCDF-B9D9-416C-95FC-006B6005E2EC@xenosoft.de> <594beaae-9681-03de-9f42-191cc7d2f8e3@xenosoft.de> <20190204075616.GA5408@lst.de> <20190204123852.GA10428@lst.de> <20190206151505.GA31065@lst.de> <20190206151655.GA31172@lst.de> <61EC67B1-12EF-42B6-B69B-B59F9E4FC474@xenosoft.de> <7c1f208b-6909-3b0a-f9f9-38ff1ac3d617@xenosoft.de> <20190208091818.GA23491@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190208091818.GA23491-jcswGhMUV9g@public.gmane.org> Content-Language: de-DE List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Darren Stevens , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Julian Margetson , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Paul Mackerras , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: linux-arch.vger.kernel.org SGkgQ2hyaXN0b3BoLAoKT24gMDggRmVicnVhcnkgMjAxOSBhdCAxMDoxOEFNLCBDaHJpc3RvcGgg SGVsbHdpZyB3cm90ZToKPiBPbiBGcmksIEZlYiAwOCwgMjAxOSBhdCAxMDowMTo0NkFNICswMTAw LCBDaHJpc3RpYW4gWmlnb3R6a3kgd3JvdGU6Cj4+IEhpIENocmlzdG9waCwKPj4KPj4gWW91ciBu ZXcgcGF0Y2ggZml4ZXMgdGhlIHByb2JsZW1zIHdpdGggdGhlIFAuQS4gU2VtaSBFdGhlcm5ldCEg Oi0pCj4gVGhhbmtzIGEgbG90IG9uY2UgYWdhaW4gZm9yIHRlc3RpbmchCj4KPiBOb3cgY2FuIHlv dSB0ZXN0IHdpdGggdGhpcyBwYXRjaCBhbmQgdGhlIHdob2xlIHNlcmllcz8KPgo+IEkndmUgdXBk YXRlZCB0aGUgcG93ZXJwYy1kbWEuNiBicmFuY2ggdG8gaW5jbHVkZSB0aGlzIGZpeC4KPgpJIHRl c3RlZCB0aGUgd2hvbGUgc2VyaWVzIHRvZGF5LiBUaGUga2VybmVscyBib290IGFuZCB0aGUgUC5B LiBTZW1pIApFdGhlcm5ldCB3b3JrcyEgOi0pIFRoYW5rcyBhIGxvdCEKCkkgYWxzbyB0ZXN0ZWQg aXQgaW4gYSB2aXJ0dWFsIGU1NTAwIFFFTVUgbWFjaGluZSB0b2RheS4gVW5mb3J0dW5hdGVseSAK dGhlIGtlcm5lbCBjcmFzaGVzLgoKTG9nOgoKW8KgwqAgNTQuNjI0MzMwXSBCVUc6IFVuYWJsZSB0 byBoYW5kbGUga2VybmVsIGRhdGEgYWNjZXNzIGF0IAoweGMwNmMwMDhhMDAxMzAxNGEKW8KgwqAg NTQuNjI1NjQwXSBGYXVsdGluZyBpbnN0cnVjdGlvbiBhZGRyZXNzOiAweGMwMDAwMDAwMDAwMjdl N2MKW8KgwqAgNTQuNjI2MTQwXSBPb3BzOiBLZXJuZWwgYWNjZXNzIG9mIGJhZCBhcmVhLCBzaWc6 IDExIFsjMV0KW8KgwqAgNTQuNjI2NDU2XSBCRSBTTVAgTlJfQ1BVUz00IFFFTVUgZTUwMApbwqDC oCA1NC42MjY4NzZdIE1vZHVsZXMgbGlua2VkIGluOgpbwqDCoCA1NC42MjcyODRdIENQVTogMSBQ SUQ6IDE4NzYgQ29tbTogc3lzdGVtZC1qb3VybmFsIE5vdCB0YWludGVkIAo1LjAuMC1yYzUtRE1B X0ExLVg1MDAwLTU0NTgxLWdkYTFkMDY1LWRpcnR5ICMxClvCoMKgIDU0LjYyNzgxOV0gTklQOsKg IGMwMDAwMDAwMDAwMjdlN2MgTFI6IGMwMDAwMDAwMDAwYjUyNjQgQ1RSOiAKMDAwMDAwMDAwMDAw MDAwMApbwqDCoCA1NC42MjgxNzNdIFJFR1M6IGMwMDAwMDAwN2ZmZWI3MDAgVFJBUDogMDMwMMKg wqAgTm90IHRhaW50ZWQgCig1LjAuMC1yYzUtRE1BX0ExLVg1MDAwLTU0NTgxLWdkYTFkMDY1LWRp cnR5KQpbwqDCoCA1NC42Mjg2MDddIE1TUjrCoCAwMDAwMDAwMDgwMDA5MDAwIDxFRSxNRT7CoCBD UjogNDQwMDg0ODYgWEVSOiAwMDAwMDAwMApbwqDCoCA1NC42MjkwMjNdIERFQVI6IGMwNmMwMDhh MDAxMzAxNGEgRVNSOiAwMDAwMDAwMDAwODAwMDAwIElSUU1BU0s6IDAKW8KgwqAgNTQuNjI5MDIz XSBHUFIwMDogMDAwMDAwMDAwMDAwNTI1NCBjMDAwMDAwMDdmZmViOTkwIGMwMDAwMDAwMDE2YjIw MDAgCmMwNmMwMDhhMDAxMzAxNGEKW8KgwqAgNTQuNjI5MDIzXSBHUFIwNDogYzAwMDAwMDA3YzU0 ZjhjMCAwMDAwMDAwMDAwMDAwMDU4IDAwMDAwMDAwMDAwMDAwMDYgCjAwMDAwMDAwMDAwMDAwMDAK W8KgwqAgNTQuNjI5MDIzXSBHUFIwODogMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDdjNTRmOGMw IDAwNmMwMDhhMDAxMzAxNGEgCmMwMDAwMDAwN2M4NmMwMDAKW8KgwqAgNTQuNjI5MDIzXSBHUFIx MjogMDAwMDAwMDAyODAwMjQ4MiBjMDAwMDAwMDNmZmZmOGMwIDAwMDAwMDAwMDAwMDAwMDAgCmMw MDAwMDAwNzhkZmFhNzAKW8KgwqAgNTQuNjI5MDIzXSBHUFIxNjogYzAwMDAwMDA3ODM2NmMwMCAw MDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwNWUgCjAwMDAwMDAwMDAwMDAwMDAKW8KgwqAg NTQuNjI5MDIzXSBHUFIyMDogMDAwMDAwMDAwMDAwMDAwMCBjMDAwMDAwMDdjNTRmOGMwIDAwMDAw MDAwMDAwMDAwMDcgCmMwMDAwMDAwNzhkZmEwMDAKW8KgwqAgNTQuNjI5MDIzXSBHUFIyNDogMDAw MDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDQ3IDAwMDAwMDAwMDAwMDAwMDAgCjgwMDAwMDAw MDAzZjY0NzAKW8KgwqAgNTQuNjI5MDIzXSBHUFIyODogYzAwMDAwMDA3OTI4ZDQ3MCBjMDAwMDAw MDc4ODAxZGMwIDAwMDAwMDAwMDAwMDAwNWUgCmMwMDAwMDAwNzhkZmE3YzAKW8KgwqAgNTQuNjMy NTcyXSBOSVAgW2MwMDAwMDAwMDAwMjdlN2NdIC5tZW1jcHkrMHgxZmMvMHgyODgKW8KgwqAgNTQu NjMyODg2XSBMUiBbYzAwMDAwMDAwMDBiNTI2NF0gLnN3aW90bGJfdGJsX3N5bmNfc2luZ2xlKzB4 YjAvMHhlNApbwqDCoCA1NC42MzMyMjFdIENhbGwgVHJhY2U6ClvCoMKgIDU0LjYzMzUxM10gW2Mw MDAwMDAwN2ZmZWI5OTBdIFtjMDAwMDAwMDdmZmViYTcwXSAweGMwMDAwMDAwN2ZmZWJhNzAgCih1 bnJlbGlhYmxlKQpbwqDCoCA1NC42MzM5ODhdIFtjMDAwMDAwMDdmZmViYTAwXSBbYzAwMDAwMDAw MDBiNDFlNF0gCi5kbWFfZGlyZWN0X3N5bmNfc2luZ2xlX2Zvcl9jcHUrMHg1OC8weDZjClvCoMKg IDU0LjYzNDQzNl0gW2MwMDAwMDAwN2ZmZWJhNzBdIFtjMDAwMDAwMDAwNzg4ZGE0XSAKLmUxMDAw X2NsZWFuX3J4X2lycSsweDFiYy8weDRjOApbwqDCoCA1NC42MzQ4NTddIFtjMDAwMDAwMDdmZmVi YjkwXSBbYzAwMDAwMDAwMDc4NjY3Y10gCi5lMTAwMF9jbGVhbisweDcxNC8weDhkNApbwqDCoCA1 NC42MzUyNjNdIFtjMDAwMDAwMDdmZmViY2MwXSBbYzAwMDAwMDAwMGEzZjE1Y10gCi5uZXRfcnhf YWN0aW9uKzB4MTFjLzB4MmE0ClvCoMKgIDU0LjYzNTcxMl0gW2MwMDAwMDAwN2ZmZWJkYjBdIFtj MDAwMDAwMDAwYzQ4YzIwXSAKLl9fZG9fc29mdGlycSsweDE1MC8weDJhOApbwqDCoCA1NC42MzYy MTFdIFtjMDAwMDAwMDdmZmViZWIwXSBbYzAwMDAwMDAwMDA2NDE4NF0gLmlycV9leGl0KzB4NmMv MHhjNApbwqDCoCA1NC42MzY1MzNdIFtjMDAwMDAwMDdmZmViZjIwXSBbYzAwMDAwMDAwMDAwNDEy NF0gLl9fZG9faXJxKzB4ODAvMHg5NApbwqDCoCA1NC42MzY5ODVdIFtjMDAwMDAwMDdmZmViZjkw XSBbYzAwMDAwMDAwMDAwZWNhMF0gLmNhbGxfZG9faXJxKzB4MTQvMHgyNApbwqDCoCA1NC42Mzcz NzFdIFtjMDAwMDAwMDdjODZmZDgwXSBbYzAwMDAwMDAwMDAwNDFjMF0gLmRvX0lSUSsweDg4LzB4 YzQKW8KgwqAgNTQuNjM3NzM3XSBbYzAwMDAwMDA3Yzg2ZmUyMF0gW2MwMDAwMDAwMDAwMTI5MjBd IApleGNfMHg1MDBfY29tbW9uKzB4ZDgvMHhkYwpbwqDCoCA1NC42MzgxMDRdIEluc3RydWN0aW9u IGR1bXA6ClvCoMKgIDU0LjYzODQ1MV0gZTg2MWZmZjggNGU4MDAwMjAgN2NkMDExMjAgN2NhNjI4 NTAgMzhlMDAwMDAgMjhhNTAwMTAgCjQwOWYwMDEwIDg4MDQwMDAwClvCoMKgIDU0LjYzODg4N10g OTgwMzAwMDAgMzhlNzAwMDEgNDA5ZTAwMTAgN2MwNzIyMmUgPDdjMDcxYjJlPiAzOGU3MDAwMiAK NDA5ZDAwMGMgN2MwNzIwMmUKW8KgwqAgNTQuNjM5NTk0XSAtLS1bIGVuZCB0cmFjZSBhNDg2MWRl N2U0YzE5OWY3IF0tLS0KW8KgwqAgNTQuNjM5ODczXQpbwqDCoCA1NS42NDA0ODRdIEtlcm5lbCBw YW5pYyAtIG5vdCBzeW5jaW5nOiBBaWVlLCBraWxsaW5nIGludGVycnVwdCBoYW5kbGVyIQpbwqDC oCA1NS42NDE1NTZdIFJlYm9vdGluZyBpbiAxODAgc2Vjb25kcy4uCgotLS0tLQoKSSB0ZXN0ZWQg d2l0aCB0aGUgZm9sbG93aW5nIFFFTVUgY29tbWFuZHM6CgouL3FlbXUtc3lzdGVtLXBwYzY0IC1N IHBwY2U1MDAgLWNwdSBlNTUwMCAtbSAyMDQ4wqAgLW5vZ3JhcGhpYyAta2VybmVsIAovaG9tZS9j aHJpc3RpYW4vRG93bmxvYWRzL3ZtbGludXgtNS4wLXJjNS0yLUFtaWdhT25lX1gxMDAwX1g1MDAw L1g1MDAwX2FuZF9RRU1VX2U1NTAwL3VJbWFnZS01LjAgCi1uaWMgdXNlcixtb2RlbD1lMTAwMCAt ZHJpdmUgCmZvcm1hdD1yYXcsZmlsZT0vaG9tZS9jaHJpc3RpYW4vRG93bmxvYWRzL01BVEVfUG93 ZXJQQ19SZW1peF8yMDE3XzAuOS5pbWcsaW5kZXg9MCxpZj12aXJ0aW8gCi1hcHBlbmQgInJ3IHJv b3Q9L2Rldi92ZGEiIC1zbXAgNAoKLi9xZW11LXN5c3RlbS1wcGM2NCAtTSBwcGNlNTAwIC1jcHUg ZTU1MDAgLW0gMjA0OCAta2VybmVsIAovaG9tZS9jaHJpc3RpYW4vRG93bmxvYWRzL3ZtbGludXgt NS4wLXJjNS0yLUFtaWdhT25lX1gxMDAwX1g1MDAwL1g1MDAwX2FuZF9RRU1VX2U1NTAwL3VJbWFn ZS01LjAgCi1kcml2ZSAKZm9ybWF0PXJhdyxmaWxlPS9ob21lL2NocmlzdGlhbi9Eb3dubG9hZHMv TUFURV9Qb3dlclBDX1JlbWl4XzIwMTdfMC45LmltZyxpbmRleD0wLGlmPXZpcnRpbyAKLW5pYyB1 c2VyLG1vZGVsPWUxMDAwIC1hcHBlbmQgInJ3IHJvb3Q9L2Rldi92ZGEiIC1kZXZpY2UgdmlydGlv LXZnYSAKLWRldmljZSB2aXJ0aW8tbW91c2UtcGNpIC1kZXZpY2UgdmlydGlvLWtleWJvYXJkLXBj aSAtdXNiIC1zb3VuZGh3IAplczEzNzAgLXNtcCA0CgpUaGUgUkM1IG9mIGtlcm5lbCA1LjAgYm9v dHMgd2l0aG91dCBhbnkgcHJvYmxlbXMgaW4gdGhpcyB2aXJ0dWFsIG1hY2hpbmUuCgpDaGVlcnMs CkNocmlzdGlhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0 dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:23561 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfBJMAa (ORCPT ); Sun, 10 Feb 2019 07:00:30 -0500 Subject: Re: use generic DMA mapping code in powerpc V4 References: <9632DCDF-B9D9-416C-95FC-006B6005E2EC@xenosoft.de> <594beaae-9681-03de-9f42-191cc7d2f8e3@xenosoft.de> <20190204075616.GA5408@lst.de> <20190204123852.GA10428@lst.de> <20190206151505.GA31065@lst.de> <20190206151655.GA31172@lst.de> <61EC67B1-12EF-42B6-B69B-B59F9E4FC474@xenosoft.de> <7c1f208b-6909-3b0a-f9f9-38ff1ac3d617@xenosoft.de> <20190208091818.GA23491@lst.de> From: Christian Zigotzky Message-ID: <4e7137db-e600-0d20-6fb2-6d0f9739aca3@xenosoft.de> Date: Sun, 10 Feb 2019 13:00:20 +0100 MIME-Version: 1.0 In-Reply-To: <20190208091818.GA23491@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: de-DE Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org Message-ID: <20190210120020.jhnGQZD8jcUVCj07XbYO4cO6vekfgsWkCG-4zZXPMMU@z> Hi Christoph, On 08 February 2019 at 10:18AM, Christoph Hellwig wrote: > On Fri, Feb 08, 2019 at 10:01:46AM +0100, Christian Zigotzky wrote: >> Hi Christoph, >> >> Your new patch fixes the problems with the P.A. Semi Ethernet! :-) > Thanks a lot once again for testing! > > Now can you test with this patch and the whole series? > > I've updated the powerpc-dma.6 branch to include this fix. > I tested the whole series today. The kernels boot and the P.A. Semi Ethernet works! :-) Thanks a lot! I also tested it in a virtual e5500 QEMU machine today. Unfortunately the kernel crashes. Log: [   54.624330] BUG: Unable to handle kernel data access at 0xc06c008a0013014a [   54.625640] Faulting instruction address: 0xc000000000027e7c [   54.626140] Oops: Kernel access of bad area, sig: 11 [#1] [   54.626456] BE SMP NR_CPUS=4 QEMU e500 [   54.626876] Modules linked in: [   54.627284] CPU: 1 PID: 1876 Comm: systemd-journal Not tainted 5.0.0-rc5-DMA_A1-X5000-54581-gda1d065-dirty #1 [   54.627819] NIP:  c000000000027e7c LR: c0000000000b5264 CTR: 0000000000000000 [   54.628173] REGS: c00000007ffeb700 TRAP: 0300   Not tainted (5.0.0-rc5-DMA_A1-X5000-54581-gda1d065-dirty) [   54.628607] MSR:  0000000080009000   CR: 44008486 XER: 00000000 [   54.629023] DEAR: c06c008a0013014a ESR: 0000000000800000 IRQMASK: 0 [   54.629023] GPR00: 0000000000005254 c00000007ffeb990 c0000000016b2000 c06c008a0013014a [   54.629023] GPR04: c00000007c54f8c0 0000000000000058 0000000000000006 0000000000000000 [   54.629023] GPR08: 0000000000000000 000000007c54f8c0 006c008a0013014a c00000007c86c000 [   54.629023] GPR12: 0000000028002482 c00000003ffff8c0 0000000000000000 c000000078dfaa70 [   54.629023] GPR16: c000000078366c00 0000000000000000 000000000000005e 0000000000000000 [   54.629023] GPR20: 0000000000000000 c00000007c54f8c0 0000000000000007 c000000078dfa000 [   54.629023] GPR24: 0000000000000000 0000000000000047 0000000000000000 80000000003f6470 [   54.629023] GPR28: c00000007928d470 c000000078801dc0 000000000000005e c000000078dfa7c0 [   54.632572] NIP [c000000000027e7c] .memcpy+0x1fc/0x288 [   54.632886] LR [c0000000000b5264] .swiotlb_tbl_sync_single+0xb0/0xe4 [   54.633221] Call Trace: [   54.633513] [c00000007ffeb990] [c00000007ffeba70] 0xc00000007ffeba70 (unreliable) [   54.633988] [c00000007ffeba00] [c0000000000b41e4] .dma_direct_sync_single_for_cpu+0x58/0x6c [   54.634436] [c00000007ffeba70] [c000000000788da4] .e1000_clean_rx_irq+0x1bc/0x4c8 [   54.634857] [c00000007ffebb90] [c00000000078667c] .e1000_clean+0x714/0x8d4 [   54.635263] [c00000007ffebcc0] [c000000000a3f15c] .net_rx_action+0x11c/0x2a4 [   54.635712] [c00000007ffebdb0] [c000000000c48c20] .__do_softirq+0x150/0x2a8 [   54.636211] [c00000007ffebeb0] [c000000000064184] .irq_exit+0x6c/0xc4 [   54.636533] [c00000007ffebf20] [c000000000004124] .__do_irq+0x80/0x94 [   54.636985] [c00000007ffebf90] [c00000000000eca0] .call_do_irq+0x14/0x24 [   54.637371] [c00000007c86fd80] [c0000000000041c0] .do_IRQ+0x88/0xc4 [   54.637737] [c00000007c86fe20] [c000000000012920] exc_0x500_common+0xd8/0xdc [   54.638104] Instruction dump: [   54.638451] e861fff8 4e800020 7cd01120 7ca62850 38e00000 28a50010 409f0010 88040000 [   54.638887] 98030000 38e70001 409e0010 7c07222e <7c071b2e> 38e70002 409d000c 7c07202e [   54.639594] ---[ end trace a4861de7e4c199f7 ]--- [   54.639873] [   55.640484] Kernel panic - not syncing: Aiee, killing interrupt handler! [   55.641556] Rebooting in 180 seconds.. ----- I tested with the following QEMU commands: ./qemu-system-ppc64 -M ppce500 -cpu e5500 -m 2048  -nographic -kernel /home/christian/Downloads/vmlinux-5.0-rc5-2-AmigaOne_X1000_X5000/X5000_and_QEMU_e5500/uImage-5.0 -nic user,model=e1000 -drive format=raw,file=/home/christian/Downloads/MATE_PowerPC_Remix_2017_0.9.img,index=0,if=virtio -append "rw root=/dev/vda" -smp 4 ./qemu-system-ppc64 -M ppce500 -cpu e5500 -m 2048 -kernel /home/christian/Downloads/vmlinux-5.0-rc5-2-AmigaOne_X1000_X5000/X5000_and_QEMU_e5500/uImage-5.0 -drive format=raw,file=/home/christian/Downloads/MATE_PowerPC_Remix_2017_0.9.img,index=0,if=virtio -nic user,model=e1000 -append "rw root=/dev/vda" -device virtio-vga -device virtio-mouse-pci -device virtio-keyboard-pci -usb -soundhw es1370 -smp 4 The RC5 of kernel 5.0 boots without any problems in this virtual machine. Cheers, Christian