Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <arnd@arndb.de>, <lukas.bulwahn@gmail.com>, <palmer@dabbelt.com>
Cc: <palmerdabbelt@google.com>, <mcgrof@kernel.org>,
	<linux-arch@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED
Date: Thu, 7 Jul 2022 12:20:22 +0000	[thread overview]
Message-ID: <4ff47e50-8702-1177-612b-73d9700e47c5@microchip.com> (raw)
In-Reply-To: <CAK8P3a32m42gT9qz+Ldvr8okYGOc=kKeoJTGNWyYT71N8tJfEA@mail.gmail.com>

+CC Palmer's current email
(idk if his google one directs, but JIC)

On 07/07/2022 13:13, Arnd Bergmann wrote:
> On Thu, Jul 7, 2022 at 1:40 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>>
>> On Wed, Oct 6, 2021 at 6:52 PM Palmer Dabbelt <palmerdabbelt@google.com> wrote:
>>>
>>> On Wed, 06 Oct 2021 08:17:38 PDT (-0700), Arnd Bergmann wrote:
>>>> On Wed, Oct 6, 2021 at 5:00 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>>>>>
>>>>> Commit 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
>>>>> introduces the config symbol GENERIC_LIB_DEVMEM_IS_ALLOWED, but then
>>>>> falsely refers to CONFIG_GENERIC_DEVMEM_IS_ALLOWED (note the missing LIB
>>>>> in the reference) in ./include/asm-generic/io.h.
>>>>>
>>>>> Luckily, ./scripts/checkkconfigsymbols.py warns on non-existing configs:
>>>>>
>>>>> GENERIC_DEVMEM_IS_ALLOWED
>>>>> Referencing files: include/asm-generic/io.h
>>>>>
>>>>> Correct the name of the config to the intended one.
>>>>>
>>>>> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
>>>>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>>>>
>>>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
>>> Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
>>>
>>> Thanks.  I'm going to assume this is going in through some other tree,
>>> but IIUC I sent the buggy patch up so LMK if you're expecting it to go
>>> through mine.
>>
>> Palmer, Arnd,
>>
>> the patch in this mail thread got lost and was not picked up yet.
>>
>> MAINTAINERS suggests that Arnd takes patches to include/asm-generic/,
>> since commit 1527aab617af ("asm-generic: list Arnd as asm-generic
>> maintainer") in 2009, but maybe the responsibility for those files has
>> actually moved on to somebody (or nobody) else and we just did not
>> record that yet in MAINTAINERS.
>>
>> Arnd, will you pick this patch and provide it further to Linus Torvalds?
>>
>> Otherwise, Palmer already suggested picking it up himself.
>>
> 
> I've applied it to the asm-generic tree and can send it as a bugfix
> pull request. I don't have any other fixer for that branch at the moment,
> so if Palmer has other fixes for the riscv tree already, it would
> save me making a pull request if he picks it up there.
> 
>         Arnd

  reply	other threads:[~2022-07-07 12:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 14:58 [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED Lukas Bulwahn
2021-10-06 15:17 ` Arnd Bergmann
2021-10-06 16:52   ` Palmer Dabbelt
2022-07-07 11:40     ` Lukas Bulwahn
2022-07-07 12:13       ` Arnd Bergmann
2022-07-07 12:20         ` Conor.Dooley [this message]
2022-07-07 13:07           ` Arnd Bergmann
2022-07-07 14:41             ` Lukas Bulwahn
2022-07-20 10:50               ` Arnd Bergmann
2022-07-21  6:52                 ` Lukas Bulwahn
2022-07-21 20:41                   ` Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ff47e50-8702-1177-612b-73d9700e47c5@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=arnd@arndb.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=mcgrof@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=palmerdabbelt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox