From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH 6/7] drm/tilcdc: clean up ifdef hacks around iowrite64 Date: Mon, 26 Jun 2017 11:55:03 +0300 Message-ID: <504da99a-838c-48ec-c5b2-6b611d587a10@ti.com> References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-7-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170622164817.25515-7-logang@deltatee.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-ntb@googlegroups.com, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Greg Kroah-Hartman , Tomi Valkeinen , Arnd Bergmann , Stephen Bates List-Id: linux-arch.vger.kernel.org T24gMDYvMjIvMTcgMTk6NDgsIExvZ2FuIEd1bnRob3JwZSB3cm90ZToKPiBOb3cgdGhhdCB3ZSBj YW4gZXhwZWN0IGlvd3JpdGU2NCB0byBhbHdheXMgZXhpc3QgdGhlIGhhY2sgaXMgbm8gbG9uZ2Vy Cj4gbmVjZXNzYXJ5IHNvIHdlIGp1c3QgY2FsbCBpb3dyaXRlNjQgZGlyZWN0bHkuCj4gCj4gU2ln bmVkLW9mZi1ieTogTG9nYW4gR3VudGhvcnBlIDxsb2dhbmdAZGVsdGF0ZWUuY29tPgo+IENjOiBK eXJpIFNhcmhhIDxqc2FyaGFAdGkuY29tPgo+IENjOiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxr ZWluZW5AdGkuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+CgpBY2tl ZC1ieTogSnlyaSBTYXJoYSA8anNhcmhhQHRpLmNvbT4KCkFuZCB0aGFua3MhCgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19yZWdzLmggfCA2IC0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3RpbGNkYy90aWxjZGNfcmVncy5oIGIvZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxjZGNfcmVn cy5oCj4gaW5kZXggZTljZTcyNTY5OGE5Li4wYjkwMTQwNWYzMGEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3RpbGNkYy90aWxjZGNfcmVncy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3RpbGNkYy90aWxjZGNfcmVncy5oCj4gQEAgLTEzMywxMyArMTMzLDcgQEAgc3RhdGljIGlubGlu ZSB2b2lkIHRpbGNkY193cml0ZTY0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiByZWcsIHU2 NCBkYXRhKQo+ICAJc3RydWN0IHRpbGNkY19kcm1fcHJpdmF0ZSAqcHJpdiA9IGRldi0+ZGV2X3By aXZhdGU7Cj4gIAl2b2lkIF9faW9tZW0gKmFkZHIgPSBwcml2LT5tbWlvICsgcmVnOwo+ICAKPiAt I2lmZGVmIGlvd3JpdGU2NAo+ICAJaW93cml0ZTY0KGRhdGEsIGFkZHIpOwo+IC0jZWxzZQo+IC0J X19pb3dtYigpOwo+IC0JLyogVGhpcyBjb21waWxlcyB0byBzdHJkICg9NjQtYml0IHdyaXRlKSBv biBBUk03ICovCj4gLQkqKHU2NCBfX2ZvcmNlICopYWRkciA9IF9fY3B1X3RvX2xlNjQoZGF0YSk7 Cj4gLSNlbmRpZgo+ICB9Cj4gIAo+ICBzdGF0aWMgaW5saW5lIHUzMiB0aWxjZGNfcmVhZChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCB1MzIgcmVnKQo+IAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelnx193.ext.ti.com ([198.47.27.77]:29619 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbdFZIz1 (ORCPT ); Mon, 26 Jun 2017 04:55:27 -0400 Subject: Re: [PATCH 6/7] drm/tilcdc: clean up ifdef hacks around iowrite64 References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-7-logang@deltatee.com> From: Jyri Sarha Message-ID: <504da99a-838c-48ec-c5b2-6b611d587a10@ti.com> Date: Mon, 26 Jun 2017 11:55:03 +0300 MIME-Version: 1.0 In-Reply-To: <20170622164817.25515-7-logang@deltatee.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-ntb@googlegroups.com, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates , Tomi Valkeinen , David Airlie Message-ID: <20170626085503.kPs0JF3MXZKXzdc2czvZu7vnf0583_9kI0p2JsCxA7s@z> On 06/22/17 19:48, Logan Gunthorpe wrote: > Now that we can expect iowrite64 to always exist the hack is no longer > necessary so we just call iowrite64 directly. > > Signed-off-by: Logan Gunthorpe > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: David Airlie Acked-by: Jyri Sarha And thanks! > --- > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > index e9ce725698a9..0b901405f30a 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > @@ -133,13 +133,7 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data) > struct tilcdc_drm_private *priv = dev->dev_private; > void __iomem *addr = priv->mmio + reg; > > -#ifdef iowrite64 > iowrite64(data, addr); > -#else > - __iowmb(); > - /* This compiles to strd (=64-bit write) on ARM7 */ > - *(u64 __force *)addr = __cpu_to_le64(data); > -#endif > } > > static inline u32 tilcdc_read(struct drm_device *dev, u32 reg) >