From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule
Date: Mon, 01 Oct 2012 09:36:10 -0600 [thread overview]
Message-ID: <5069B86A.2060100@wwwdotorg.org> (raw)
In-Reply-To: <20120929200828.GD31527-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
On 09/29/2012 02:08 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:32 Fri 28 Sep , Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> All architectures that use cmd_dtc do so in the same way. Move the build
>> rule to a central location to avoid duplication.
>>
>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> Jean-Christophe,
>> Moving the build rule to Makefile.lib rather than Makefile.build seems
>> reasonable to me; the dtc-related logic is already in Makefile.lib, and
>> for features where cmd_* is defined in Makefile.lib, the associated
>> build rule is also defined there. I see no reason for this patch series
>> to move all the dtc-related logic into Makefile.build.
>
> build rules are in Makefile.build c to o , s to o etc...
As I explicitly pointed out above, your statement is simply not true;
there are many build rules in Makefile.lib.
> so put it in Makefile.build is the correct place ditto fot the dtc cmd
As such, I'm just going to ignore that feedback. Perhaps the kbuild
maintainer (oops, who I forgot to CC; I'll forward him the patches) can
weigh in though.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
Jon Loeliger <jdl@jdl.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Scott Wood <scottwood@freescale.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule
Date: Mon, 01 Oct 2012 09:36:10 -0600 [thread overview]
Message-ID: <5069B86A.2060100@wwwdotorg.org> (raw)
Message-ID: <20121001153610.CUORncRHi73opjHmsrAhFYXwVaQrCAqiJ2J9OJm2pP0@z> (raw)
In-Reply-To: <20120929200828.GD31527@game.jcrosoft.org>
On 09/29/2012 02:08 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:32 Fri 28 Sep , Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> All architectures that use cmd_dtc do so in the same way. Move the build
>> rule to a central location to avoid duplication.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> Jean-Christophe,
>> Moving the build rule to Makefile.lib rather than Makefile.build seems
>> reasonable to me; the dtc-related logic is already in Makefile.lib, and
>> for features where cmd_* is defined in Makefile.lib, the associated
>> build rule is also defined there. I see no reason for this patch series
>> to move all the dtc-related logic into Makefile.build.
>
> build rules are in Makefile.build c to o , s to o etc...
As I explicitly pointed out above, your statement is simply not true;
there are many build rules in Makefile.lib.
> so put it in Makefile.build is the correct place ditto fot the dtc cmd
As such, I'm just going to ignore that feedback. Perhaps the kbuild
maintainer (oops, who I forgot to CC; I'll forward him the patches) can
weigh in though.
next prev parent reply other threads:[~2012-10-01 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 19:32 [RFC PATCH 0/2] dtc: enable use of pre-processor Stephen Warren
2012-09-28 19:32 ` Stephen Warren
2012-09-28 19:32 ` [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule Stephen Warren
2012-09-28 19:32 ` Stephen Warren
2012-09-29 20:08 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-29 20:08 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120929200828.GD31527-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-10-01 15:36 ` Stephen Warren [this message]
2012-10-01 15:36 ` Stephen Warren
[not found] ` <1348860731-20868-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-28 19:32 ` [RFC PATCH 2/2] kbuild: introduce cmd_dtc_cpp Stephen Warren
2012-09-28 19:32 ` Stephen Warren
[not found] ` <1348860731-20868-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-29 20:02 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-29 20:02 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 20:39 ` [RFC PATCH 0/2] dtc: enable use of pre-processor Jon Loeliger
2012-09-28 20:39 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5069B86A.2060100@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox