From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule Date: Mon, 01 Oct 2012 09:36:10 -0600 Message-ID: <5069B86A.2060100@wwwdotorg.org> References: <1348860731-20868-1-git-send-email-swarren@wwwdotorg.org> <1348860731-20868-2-git-send-email-swarren@wwwdotorg.org> <20120929200828.GD31527@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120929200828.GD31527-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jean-Christophe PLAGNIOL-VILLARD Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Mark Brown , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Scott Wood List-Id: linux-arch.vger.kernel.org On 09/29/2012 02:08 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 13:32 Fri 28 Sep , Stephen Warren wrote: >> From: Stephen Warren >> >> All architectures that use cmd_dtc do so in the same way. Move the build >> rule to a central location to avoid duplication. >> >> Signed-off-by: Stephen Warren >> --- >> Jean-Christophe, >> Moving the build rule to Makefile.lib rather than Makefile.build seems >> reasonable to me; the dtc-related logic is already in Makefile.lib, and >> for features where cmd_* is defined in Makefile.lib, the associated >> build rule is also defined there. I see no reason for this patch series >> to move all the dtc-related logic into Makefile.build. > > build rules are in Makefile.build c to o , s to o etc... As I explicitly pointed out above, your statement is simply not true; there are many build rules in Makefile.lib. > so put it in Makefile.build is the correct place ditto fot the dtc cmd As such, I'm just going to ignore that feedback. Perhaps the kbuild maintainer (oops, who I forgot to CC; I'll forward him the patches) can weigh in though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:46910 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab2JAPgP (ORCPT ); Mon, 1 Oct 2012 11:36:15 -0400 Message-ID: <5069B86A.2060100@wwwdotorg.org> Date: Mon, 01 Oct 2012 09:36:10 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [RFC PATCH 1/2] kbuild: centralize .dts->.dtb rule References: <1348860731-20868-1-git-send-email-swarren@wwwdotorg.org> <1348860731-20868-2-git-send-email-swarren@wwwdotorg.org> <20120929200828.GD31527@game.jcrosoft.org> In-Reply-To: <20120929200828.GD31527@game.jcrosoft.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jean-Christophe PLAGNIOL-VILLARD Cc: David Gibson , Jon Loeliger , Grant Likely , Rob Herring , Scott Wood , Mark Brown , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Stephen Warren Message-ID: <20121001153610.CUORncRHi73opjHmsrAhFYXwVaQrCAqiJ2J9OJm2pP0@z> On 09/29/2012 02:08 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 13:32 Fri 28 Sep , Stephen Warren wrote: >> From: Stephen Warren >> >> All architectures that use cmd_dtc do so in the same way. Move the build >> rule to a central location to avoid duplication. >> >> Signed-off-by: Stephen Warren >> --- >> Jean-Christophe, >> Moving the build rule to Makefile.lib rather than Makefile.build seems >> reasonable to me; the dtc-related logic is already in Makefile.lib, and >> for features where cmd_* is defined in Makefile.lib, the associated >> build rule is also defined there. I see no reason for this patch series >> to move all the dtc-related logic into Makefile.build. > > build rules are in Makefile.build c to o , s to o etc... As I explicitly pointed out above, your statement is simply not true; there are many build rules in Makefile.lib. > so put it in Makefile.build is the correct place ditto fot the dtc cmd As such, I'm just going to ignore that feedback. Perhaps the kbuild maintainer (oops, who I forgot to CC; I'll forward him the patches) can weigh in though.