From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [RESEND PATCH 4/4] net: smc91x: use io{read,write}*_rep accessors instead of string functions Date: Fri, 19 Oct 2012 09:25:48 +0100 Message-ID: <50810E8C.5010806@imgtec.com> References: <1350488704-3711-1-git-send-email-will.deacon@arm.com> <1350488704-3711-5-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1350488704-3711-5-git-send-email-will.deacon@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Ben Herrenschmidt List-Id: linux-arch.vger.kernel.org On 17/10/12 16:45, Will Deacon wrote: > The {read,write}s{b,w,l} operations are not defined by all architectures > and are being removed from the asm-generic/io.h interface. > > This patch replaces the usage of these string functions in the default > SMC accessors with io{read,write}{8,16,32}_rep calls instead, which are > defined for all architectures. Hi, Should this patch (and the mmc one) precede patch 1? Also there appear to be some other places that it's used (e.g. smsc911x.c and smc911x.h). I guess these should be fixed up first too? Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from multi.imgtec.com ([194.200.65.239]:45919 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753848Ab2JSIlz (ORCPT ); Fri, 19 Oct 2012 04:41:55 -0400 Message-ID: <50810E8C.5010806@imgtec.com> Date: Fri, 19 Oct 2012 09:25:48 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [RESEND PATCH 4/4] net: smc91x: use io{read,write}*_rep accessors instead of string functions References: <1350488704-3711-1-git-send-email-will.deacon@arm.com> <1350488704-3711-5-git-send-email-will.deacon@arm.com> In-Reply-To: <1350488704-3711-5-git-send-email-will.deacon@arm.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Ben Herrenschmidt Message-ID: <20121019082548.VGw2IvBpCe0nNvWf8UJQ6bprvc25TA3_pXXZBFdoF84@z> On 17/10/12 16:45, Will Deacon wrote: > The {read,write}s{b,w,l} operations are not defined by all architectures > and are being removed from the asm-generic/io.h interface. > > This patch replaces the usage of these string functions in the default > SMC accessors with io{read,write}{8,16,32}_rep calls instead, which are > defined for all architectures. Hi, Should this patch (and the mmc one) precede patch 1? Also there appear to be some other places that it's used (e.g. smsc911x.c and smc911x.h). I guess these should be fixed up first too? Cheers James