From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include Date: Mon, 29 Oct 2012 09:28:09 +0000 Message-ID: <508E4C29.4030308@imgtec.com> References: <1350984117-17369-1-git-send-email-james.hogan@imgtec.com> <57835.162.105.203.8.1351474122.squirrel@mprc.pku.edu.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Return-path: Received: from multi.imgtec.com ([194.200.65.239]:55735 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753287Ab2J2J2O (ORCPT ); Mon, 29 Oct 2012 05:28:14 -0400 In-Reply-To: <57835.162.105.203.8.1351474122.squirrel@mprc.pku.edu.cn> Sender: linux-arch-owner@vger.kernel.org List-ID: To: guanxuetao@mprc.pku.edu.cn Cc: Arnd Bergmann , Jonas Bonn , linux-arch@vger.kernel.org, linux@openrisc.net, linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linux-xtensa@linux-xtensa.org, Chris Zankel , Max Filippov , Mike Frysinger , Chen Liqin , Lennox Wu , Guan Xuetao On 29/10/12 01:28, guanxuetao@mprc.pku.edu.cn wrote: >> Including from prevents >> cacheflush.h being able to use I/O functions like readl and writel due >> to circular include dependencies. It doesn't appear as if anything from >> cacheflush.h is actually used by the generic io.h, so remove the >> include. >> >> I've compile tested a defconfig compilation of blackfin, openrisc (which >> needed including from it's to get the PAGE_* >> definitions), and xtensa. >> >> Other architectures which use asm-generic/io.h are score and unicore32, >> and looking at their io.h I don't see any obvious problems. >> >> Signed-off-by: James Hogan >> Cc: Arnd Bergmann >> Cc: Jonas Bonn >> Cc: Chris Zankel >> Cc: Max Filippov >> Cc: Mike Frysinger >> Cc: Chen Liqin >> Cc: Lennox Wu >> Cc: Guan Xuetao > > Acked-by: Guan Xuetao Thanks Guan Cheers James