From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet Gupta Subject: Re: [RFC Patch v1 38/55] ARC: Low level event capture/logging Date: Thu, 15 Nov 2012 16:10:53 +0530 Message-ID: <50A4C6B5.9010500@synopsys.com> References: <1352720953-24321-1-git-send-email-vgupta@synopsys.com> <1352720953-24321-8-git-send-email-vgupta@synopsys.com> <201211121355.23947.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from us01smtp2.synopsys.com ([198.182.44.80]:39137 "EHLO kiruna.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964838Ab2KOKnh (ORCPT ); Thu, 15 Nov 2012 05:43:37 -0500 In-Reply-To: <201211121355.23947.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de On Monday 12 November 2012 07:25 PM, Arnd Bergmann wrote: > On Monday 12 November 2012, Vineet.Gupta1@synopsys.com wrote: >> +EXPORT_SYMBOL(take_snap); >> + >> ... >> +EXPORT_SYMBOL(take_snap2); > Where are these functions called? These are called from various parts of ARCH code, such as before handling signal or TLB flush etc. > Shouldn't this all just be part of the perf module? These are for low level ARCH specific event snapshotting. Maybe perf/ftrace already have some of these in the generic code which eventually call the ARCH APIs. Our current perf support is just husk of an implementation. Once we have the full perf / ftrace support this module - except for the even t capture part could just go away. OTOH, I've not seen much usage of this from loadable modules - so if you deem correct, I can even remove the export. > If not, can you make the exports GPL-only? Am I right in understanding that this is more related to discouraging non GPL modules "in general" than having to do with port itself. > > Arnd