From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet Gupta Subject: Re: [PATCH v3 32/71] ARC: [DeviceTree] Basic support Date: Tue, 29 Jan 2013 19:09:16 +0530 Message-ID: <5107D104.5050304@synopsys.com> References: <1359024639-21915-1-git-send-email-vgupta@synopsys.com> <1359024639-21915-15-git-send-email-vgupta@synopsys.com> <5107CDD3.3050502@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5107CDD3.3050502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Rob Herring Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arch.vger.kernel.org On Tuesday 29 January 2013 06:55 PM, Rob Herring wrote: > On 01/24/2013 04:50 AM, Vineet Gupta wrote: >> This is minimal infrastructure needed for devicetree work. >> It uses an a sample "skeleton" devicetree - embedded in kernel image - >> to print the board, manufacturer by parsing the top-level "compatible" >> string. >> >> As of now we don't need any additional "board" specific "machine_desc". >> >> TODO: support interpreting the command line as boot-loader passed dtb >> >> Signed-off-by: Vineet Gupta >> Cc: Arnd Bergmann >> Cc: Grant Likely >> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org >> Cc: Rob Herring > One minor thing below, otherwise: > > Reviewed-by: Rob Herring > > >> diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c >> new file mode 100644 >> index 0000000..229f78e >> --- /dev/null >> +++ b/arch/arc/kernel/devtree.c >> @@ -0,0 +1,69 @@ >> +/* >> + * Copyright (C) 2012 Synopsys, Inc. (www.synopsys.com) >> + * >> + * Based on highly stipped down version of METAG >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> + >> +#include >> +#include >> +#include > Is this include needed? Nope - removed. > >> +#include >> +#include > And this? reboot.h is needed for the machine_halt() prototype. > >> +#include >> +#include >> +#include >> +#include > And this? > >> +#include > And this? Both of the above removed. I'll send a revised patch which also addresses James' review comments as well - (namely broken dtbs rule, adding dependency on scripts ...) See https://lkml.org/lkml/2013/1/28/138 for reference. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us01smtp3.synopsys.com ([198.182.44.81]:44207 "EHLO hermes.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756906Ab3A2Njv (ORCPT ); Tue, 29 Jan 2013 08:39:51 -0500 Message-ID: <5107D104.5050304@synopsys.com> Date: Tue, 29 Jan 2013 19:09:16 +0530 From: Vineet Gupta MIME-Version: 1.0 Subject: Re: [PATCH v3 32/71] ARC: [DeviceTree] Basic support References: <1359024639-21915-1-git-send-email-vgupta@synopsys.com> <1359024639-21915-15-git-send-email-vgupta@synopsys.com> <5107CDD3.3050502@gmail.com> In-Reply-To: <5107CDD3.3050502@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Grant Likely , devicetree-discuss@lists.ozlabs.org Message-ID: <20130129133916.lcQ8OIz3ouI9pqZ7bq4tt23GzBbEy0_yfqniBII6Xx4@z> On Tuesday 29 January 2013 06:55 PM, Rob Herring wrote: > On 01/24/2013 04:50 AM, Vineet Gupta wrote: >> This is minimal infrastructure needed for devicetree work. >> It uses an a sample "skeleton" devicetree - embedded in kernel image - >> to print the board, manufacturer by parsing the top-level "compatible" >> string. >> >> As of now we don't need any additional "board" specific "machine_desc". >> >> TODO: support interpreting the command line as boot-loader passed dtb >> >> Signed-off-by: Vineet Gupta >> Cc: Arnd Bergmann >> Cc: Grant Likely >> Cc: devicetree-discuss@lists.ozlabs.org >> Cc: Rob Herring > One minor thing below, otherwise: > > Reviewed-by: Rob Herring > > >> diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c >> new file mode 100644 >> index 0000000..229f78e >> --- /dev/null >> +++ b/arch/arc/kernel/devtree.c >> @@ -0,0 +1,69 @@ >> +/* >> + * Copyright (C) 2012 Synopsys, Inc. (www.synopsys.com) >> + * >> + * Based on highly stipped down version of METAG >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> + >> +#include >> +#include >> +#include > Is this include needed? Nope - removed. > >> +#include >> +#include > And this? reboot.h is needed for the machine_halt() prototype. > >> +#include >> +#include >> +#include >> +#include > And this? > >> +#include > And this? Both of the above removed. I'll send a revised patch which also addresses James' review comments as well - (namely broken dtbs rule, adding dependency on scripts ...) See https://lkml.org/lkml/2013/1/28/138 for reference.