From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH v3 40/71] ARC: OProfile support Date: Wed, 30 Jan 2013 10:54:53 +0000 Message-ID: <5108FBFD.8080705@imgtec.com> References: <1359025589-22277-1-git-send-email-vgupta@synopsys.com> <1359025589-22277-25-git-send-email-vgupta@synopsys.com> <5108016B.5050303@imgtec.com> <5108BEF5.6030500@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from multi.imgtec.com ([194.200.65.239]:39836 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753704Ab3A3Ky4 (ORCPT ); Wed, 30 Jan 2013 05:54:56 -0500 In-Reply-To: <5108BEF5.6030500@synopsys.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Vineet Gupta Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Robert Richter , oprofile-list@lists.sf.net On 30/01/13 06:34, Vineet Gupta wrote: > On Tuesday 29 January 2013 10:35 PM, James Hogan wrote: >> Hi Vineet, >> >> You don't appear to define CONFIG_HW_PERF_EVENTS, so >> include/linux/oprofile.h will presumably define oprofile_perf_init as >> just a pr_info(...); return -ENODEV; >> >> Similarly drivers/oprofile/oprofile_perf.o doesn't seem to be being built. >> >> I'm probably missing something somewhere? > > Not much :-) > > oprofile_arch_init() failure causes oprofile to fall back to timer based PC only > sampling - for coarse grained profiling. I'll soon be starting on integratign the > hardware counter support to both oprofile/perf. Okay cool. It's just slightly misleading for anybody copying the code that it calls oprofile_perf_init which is known never to do anything :-). Maybe it's worth adding a comment in there to clarify. If it's only temporary I'm fine with it. Reviewed-by: James Hogan Cheers James