From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-arch@vger.kernel.org, oprofile-list@lists.sf.net,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH v3 40/71] ARC: OProfile support
Date: Wed, 30 Jan 2013 17:16:17 +0530 [thread overview]
Message-ID: <51090809.8010801@synopsys.com> (raw)
In-Reply-To: <5108FBFD.8080705@imgtec.com>
On Wednesday 30 January 2013 04:24 PM, James Hogan wrote:
> On 30/01/13 06:34, Vineet Gupta wrote:
>> On Tuesday 29 January 2013 10:35 PM, James Hogan wrote:
>>> Hi Vineet,
>>>
>>> You don't appear to define CONFIG_HW_PERF_EVENTS, so
>>> include/linux/oprofile.h will presumably define oprofile_perf_init as
>>> just a pr_info(...); return -ENODEV;
>>>
>>> Similarly drivers/oprofile/oprofile_perf.o doesn't seem to be being built.
>>>
>>> I'm probably missing something somewhere?
>> Not much :-)
>>
>> oprofile_arch_init() failure causes oprofile to fall back to timer based PC only
>> sampling - for coarse grained profiling. I'll soon be starting on integratign the
>> hardware counter support to both oprofile/perf.
> Okay cool. It's just slightly misleading for anybody copying the code
> that it calls oprofile_perf_init which is known never to do anything
> :-). Maybe it's worth adding a comment in there to clarify.
I think banner comment in oprofile.h for oprofile_arch_init() needs to document
that "in case it fails, oprofile switches to timer mode PC sampling".
But nevertheless it's good idea to add that clarification in my code anyways.
>
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
Thx,
-Vineet
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, Robert Richter <rric@kernel.org>,
oprofile-list@lists.sf.net
Subject: Re: [PATCH v3 40/71] ARC: OProfile support
Date: Wed, 30 Jan 2013 17:16:17 +0530 [thread overview]
Message-ID: <51090809.8010801@synopsys.com> (raw)
Message-ID: <20130130114617.2SvwfzF1qtXeQwaAriKHgqtc_a3kl7K-Jjqt6eUxxP0@z> (raw)
In-Reply-To: <5108FBFD.8080705@imgtec.com>
On Wednesday 30 January 2013 04:24 PM, James Hogan wrote:
> On 30/01/13 06:34, Vineet Gupta wrote:
>> On Tuesday 29 January 2013 10:35 PM, James Hogan wrote:
>>> Hi Vineet,
>>>
>>> You don't appear to define CONFIG_HW_PERF_EVENTS, so
>>> include/linux/oprofile.h will presumably define oprofile_perf_init as
>>> just a pr_info(...); return -ENODEV;
>>>
>>> Similarly drivers/oprofile/oprofile_perf.o doesn't seem to be being built.
>>>
>>> I'm probably missing something somewhere?
>> Not much :-)
>>
>> oprofile_arch_init() failure causes oprofile to fall back to timer based PC only
>> sampling - for coarse grained profiling. I'll soon be starting on integratign the
>> hardware counter support to both oprofile/perf.
> Okay cool. It's just slightly misleading for anybody copying the code
> that it calls oprofile_perf_init which is known never to do anything
> :-). Maybe it's worth adding a comment in there to clarify.
I think banner comment in oprofile.h for oprofile_arch_init() needs to document
that "in case it fails, oprofile switches to timer mode PC sampling".
But nevertheless it's good idea to add that clarification in my code anyways.
>
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
Thx,
-Vineet
next prev parent reply other threads:[~2013-01-30 11:46 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 11:05 [PATCH v3 00/71] Synopsys ARC Linux kernel Port (Part #2) Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 03/71] ARC: irqflags - Interrupt enabling/disabling at in-core intc Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 04/71] ARC: Atomic/bitops/cmpxchg/barriers Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 05/71] asm-generic headers: uaccess.h to conditionally define segment_eq() Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 07/71] asm-generic: uaccess: Allow arches to over-ride __{get,put}_user_fn() Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 08/71] ARC: [optim] uaccess __{get,put}_user() optimised Vineet Gupta
2013-01-24 11:05 ` Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 09/71] asm-generic headers: Allow yet more arch overrides in checksum.h Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 10/71] ARC: Checksum/byteorder/swab routines Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 12/71] ARC: Spinlock/rwlock/mutex primitives Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 13/71] ARC: String library Vineet Gupta
2013-01-24 11:05 ` Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 14/71] ARC: Low level IRQ/Trap/Exception Handling Vineet Gupta
2013-01-28 7:44 ` Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 15/71] ARC: Interrupt Handling Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 16/71] ARC: Non-MMU Exception Handling Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 24/71] ARC: Page Table Management Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 25/71] ARC: MMU Context Management Vineet Gupta
2013-01-24 11:05 ` Vineet Gupta
2013-01-24 11:05 ` [PATCH v3 26/71] ARC: MMU Exception Handling Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 27/71] ARC: TLB flush Handling Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 28/71] ARC: Page Fault handling Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 31/71] ARC: [plat-arcfpga] Static platform device for CONFIG_SERIAL_ARC Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 35/71] ARC: Last bits (stubs) to get to a running kernel with UART Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 36/71] ARC: [plat-arcfpga] defconfig Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 37/71] ARC: [optim] Cache "current" in Register r25 Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 38/71] ARC: ptrace support Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 39/71] ARC: Futex support Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 40/71] ARC: OProfile support Vineet Gupta
2013-01-29 17:05 ` James Hogan
2013-01-30 6:34 ` Vineet Gupta
2013-01-30 10:54 ` James Hogan
2013-01-30 11:46 ` Vineet Gupta [this message]
2013-01-30 11:46 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 41/71] ARC: Support for high priority interrupts in the in-core intc Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 43/71] ARC: Diagnostics: show_regs() etc Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 46/71] ARC: stacktracing APIs based on dw2 unwinder Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 47/71] ARC: disassembly (needed by kprobes/kgdb/unaligned-access-emul) Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 49/71] sysctl: Enable PARISC "unaligned-trap" to be used cross-arch Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 50/71] ARC: Unaligned access emulation Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 51/71] ARC: kgdb support Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 52/71] ARC: Boot #2: Verbose Boot reporting / feature verification Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 53/71] ARC: [plat-arfpga] BVCI Latency Unit setup Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 54/71] perf, ARC: Enable building perf tools for ARC Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 55/71] ARC: perf support (software counters only) Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 56/71] ARC: Support for single cycle Close Coupled Mem (CCM) Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 60/71] ARC: [Review] Multi-platform image #1: Kconfig enablement Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 61/71] ARC: Fold boards sub-menu into platform/SoC menu Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 63/71] ARC: [Review] Multi-platform image #3: switch to board callback Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 64/71] ARC: [Review] Multi-platform image #4: Isolate platform headers Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 65/71] ARC: [Review] Multi-platform image #5: NR_IRQS defined by ARC core Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 66/71] ARC: [Review] Multi-platform image #6: cpu-to-dma-addr optional Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 67/71] ARC: [Review] Multi-platform image #7: SMP common code to use callbacks Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 68/71] ARC: [Review] Multi-platform image #8: platform registers SMP callbacks Vineet Gupta
2013-01-24 11:06 ` Vineet Gupta
2013-01-24 11:06 ` [PATCH v3 71/71] ARC: Add self to MAINTAINERS Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51090809.8010801@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=james.hogan@imgtec.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).