From: Jiang Liu <liuj97@gmail.com> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Jiang Liu <jiang.liu@huawei.com>, David Rientjes <rientjes@google.com>, Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Michal Hocko <mhocko@suse.cz>, James Bottomley <James.Bottomley@HansenPartnership.com>, David Howells <dhowells@redhat.com>, Mark Salter <msalter@redhat.com>, Jianguo Wu <wujianguo@huawei.com>, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Chen <tangchen@cn.fujitsu.com>, Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: [PATCH v4, part3 08/15] mm: fix some trivial typos in comments Date: Sat, 06 Apr 2013 22:45:42 +0800 [thread overview] Message-ID: <51603516.4040002@gmail.com> (raw) In-Reply-To: <516032EC.9080905@cogentembedded.com> On 04/06/2013 10:36 PM, Sergei Shtylyov wrote: > Hello. > > On 06-04-2013 17:55, Jiang Liu wrote: > >> Fix some trivial typos in comments. > >> Signed-off-by: Jiang Liu <jiang.liu@huawei.com> >> Cc: Wen Congyang <wency@cn.fujitsu.com> >> Cc: Tang Chen <tangchen@cn.fujitsu.com> >> Cc: Jiang Liu <jiang.liu@huawei.com> >> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >> Cc: Mel Gorman <mgorman@suse.de> >> Cc: Minchan Kim <minchan@kernel.org> >> Cc: Marek Szyprowski <m.szyprowski@samsung.com> >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org > [...] > >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 57decb2..a5b8fde 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -309,7 +309,7 @@ static int __meminit move_pfn_range_left(struct zone *z1, struct zone *z2, >> /* can't move pfns which are higher than @z2 */ >> if (end_pfn > zone_end_pfn(z2)) >> goto out_fail; >> - /* the move out part mast at the left most of @z2 */ >> + /* the move out part must at the left most of @z2 */ > > Maybe "must be"? Good catch! > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 6bd697c..c3c3eda 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -2863,7 +2863,7 @@ EXPORT_SYMBOL(free_pages_exact); >> * nr_free_zone_pages() counts the number of counts pages which are beyond the >> * high watermark within all zones at or below a given zone index. For each >> * zone, the number of pages is calculated as: >> - * present_pages - high_pages >> + * managed_pages - high_pages > > I'm not sure it's that trivial. We just changes the comments to follow the code, so mark it as "trivial". Regards! Gerry > > WBR, Sergei > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Liu <liuj97@gmail.com> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Jiang Liu <jiang.liu@huawei.com>, David Rientjes <rientjes@google.com>, Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Michal Hocko <mhocko@suse.cz>, James Bottomley <James.Bottomley@HansenPartnership.com>, David Howells <dhowells@redhat.com>, Mark Salter <msalter@redhat.com>, Jianguo Wu <wujianguo@huawei.com>, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Chen <tangchen@cn.fujitsu.com>, Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: [PATCH v4, part3 08/15] mm: fix some trivial typos in comments Date: Sat, 06 Apr 2013 22:45:42 +0800 [thread overview] Message-ID: <51603516.4040002@gmail.com> (raw) Message-ID: <20130406144542.YbY3OlDsqtNx32uan8lk78tYMDSegEb12YWICQ8U8xs@z> (raw) In-Reply-To: <516032EC.9080905@cogentembedded.com> On 04/06/2013 10:36 PM, Sergei Shtylyov wrote: > Hello. > > On 06-04-2013 17:55, Jiang Liu wrote: > >> Fix some trivial typos in comments. > >> Signed-off-by: Jiang Liu <jiang.liu@huawei.com> >> Cc: Wen Congyang <wency@cn.fujitsu.com> >> Cc: Tang Chen <tangchen@cn.fujitsu.com> >> Cc: Jiang Liu <jiang.liu@huawei.com> >> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >> Cc: Mel Gorman <mgorman@suse.de> >> Cc: Minchan Kim <minchan@kernel.org> >> Cc: Marek Szyprowski <m.szyprowski@samsung.com> >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org > [...] > >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 57decb2..a5b8fde 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -309,7 +309,7 @@ static int __meminit move_pfn_range_left(struct zone *z1, struct zone *z2, >> /* can't move pfns which are higher than @z2 */ >> if (end_pfn > zone_end_pfn(z2)) >> goto out_fail; >> - /* the move out part mast at the left most of @z2 */ >> + /* the move out part must at the left most of @z2 */ > > Maybe "must be"? Good catch! > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 6bd697c..c3c3eda 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -2863,7 +2863,7 @@ EXPORT_SYMBOL(free_pages_exact); >> * nr_free_zone_pages() counts the number of counts pages which are beyond the >> * high watermark within all zones at or below a given zone index. For each >> * zone, the number of pages is calculated as: >> - * present_pages - high_pages >> + * managed_pages - high_pages > > I'm not sure it's that trivial. We just changes the comments to follow the code, so mark it as "trivial". Regards! Gerry > > WBR, Sergei >
next prev parent reply other threads:[~2013-04-06 14:45 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-06 13:54 [PATCH v4, part3 00/15] accurately calculate memory statisitic information Jiang Liu 2013-04-06 13:54 ` Jiang Liu 2013-04-06 13:54 ` [PATCH v4, part3 01/15] mm: fix build warnings caused by free_reserved_area() Jiang Liu 2013-04-06 13:54 ` Jiang Liu 2013-04-19 16:52 ` Russell King - ARM Linux 2013-04-20 15:34 ` Jiang Liu 2013-04-20 15:34 ` Jiang Liu 2013-04-06 13:54 ` [PATCH v4, part3 02/15] mm: enhance free_reserved_area() to support poisoning memory with zero Jiang Liu 2013-04-06 13:54 ` Jiang Liu 2013-04-06 13:54 ` [PATCH v4, part3 03/15] mm/ARM64: kill poison_init_mem() Jiang Liu 2013-04-06 13:54 ` Jiang Liu 2013-04-06 13:54 ` [PATCH v4, part3 04/15] mm/x86: use free_reserved_area() to simplify code Jiang Liu 2013-04-06 13:54 ` [PATCH v4, part3 05/15] mm/tile: use common help functions to free reserved pages Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 06/15] mm, powertv: use free_reserved_area() to simplify code Jiang Liu 2013-04-06 13:55 ` Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 07/15] mm, acornfb: " Jiang Liu 2013-04-06 13:55 ` Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 08/15] mm: fix some trivial typos in comments Jiang Liu 2013-04-06 13:55 ` Jiang Liu 2013-04-06 14:36 ` Sergei Shtylyov 2013-04-06 14:36 ` Sergei Shtylyov 2013-04-06 14:45 ` Jiang Liu [this message] 2013-04-06 14:45 ` Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 09/15] mm: use managed_pages to calculate default zonelist order Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 10/15] mm: accurately calculate zone->managed_pages for highmem zones Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 11/15] mm: use a dedicated lock to protect totalram_pages and zone->managed_pages Jiang Liu 2013-04-06 13:55 ` Jiang Liu 2013-04-08 13:39 ` Rik van Riel 2013-04-08 13:39 ` Rik van Riel 2013-04-08 16:05 ` Jiang Liu 2013-04-08 16:05 ` Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 12/15] mm: make __free_pages_bootmem() only available at boot time Jiang Liu 2013-04-06 13:55 ` Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 13/15] mm: correctly update zone->mamaged_pages Jiang Liu 2013-04-06 13:55 ` Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 14/15] mm: concentrate modification of totalram_pages into the mm core Jiang Liu 2013-04-06 13:55 ` [PATCH v4, part3 15/15] mm: report available pages as "MemTotal" for each NUMA node Jiang Liu 2013-04-07 1:34 ` [PATCH v4, part3 00/15] accurately calculate memory statisitic information Simon Jeons 2013-04-07 1:34 ` Simon Jeons 2013-04-07 15:08 ` Jiang Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51603516.4040002@gmail.com \ --to=liuj97@gmail.com \ --cc=James.Bottomley@HansenPartnership.com \ --cc=akpm@linux-foundation.org \ --cc=dhowells@redhat.com \ --cc=isimatu.yasuaki@jp.fujitsu.com \ --cc=jiang.liu@huawei.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=m.szyprowski@samsung.com \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=minchan@kernel.org \ --cc=msalter@redhat.com \ --cc=rientjes@google.com \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=tangchen@cn.fujitsu.com \ --cc=wency@cn.fujitsu.com \ --cc=wujianguo@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).