From: Alex Courbot <acourbot@nvidia.com>
To: Christian Ruppert <christian.ruppert@abilis.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch <linux-arch@vger.kernel.org>,
Pierrick Hascoet <pierrick.hascoet@abilis.com>,
sascha leuenberger <sascha.leuenberger@abilis.com>
Subject: Re: [PATCH v2 0/4] remove GENERIC_GPIO
Date: Tue, 16 Apr 2013 18:01:13 +0900 [thread overview]
Message-ID: <516D1359.2080609@nvidia.com> (raw)
In-Reply-To: <20130416073459.GA30238@ab42.lan>
Hi Christian,
On 04/16/2013 04:34 PM, Christian Ruppert wrote:
> Thanks for taking a look at the driver. I think the issue we see is due
> to the fact that "Platforms must declare GENERIC_GPIO support in their
> Kconfig (boolean true)" (from Documentation/gpio.txt). This seems to be
> still the case at the moment and I haven't found a way around it.
> Removing the config GENERIC_GPIO section from our platform's Kconfig
> (see arch/arc/plat-tb10x/Kconfig in linux-next) results in compilation
> errors. This seems logical since "config GPIOLIB" only selects
> GENERIC_GPIO but assumes it is defined elsewhere.
>
> We were wondering if we could get rid of the "config GENERIC_GPIO"
> section in the new platform's Kconfig in order to avoid adding things
> you are going to remove again soon and in order to check if there aren't
> any hidden dependencies on GENERIC_GPIO in the driver. Do I understand
> your mail correctly that this is not yet possible?
Oh, then it looks like *I* did not understand your mail correctly. It is
absolutely necessary indeed that your architecture declares a
GENERIC_GPIO config option. What I was trying to prevent you from doing
was to put new "select GENERIC_GPIO" or "depends on GENERIC_GPIO" in
your Kconfig files.
If the only reference to GENERIC_GPIO in your architecture or drivers is
the declaration of this config option, then it is perfectly fine - I
will take care of removing it when the time is right.
So I guess you guys are just fine - sorry about the misunderstanding!
Thanks,
Alex.
next prev parent reply other threads:[~2013-04-16 9:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 18:32 [PATCH v2 0/4] remove GENERIC_GPIO Alexandre Courbot
2013-04-08 18:32 ` [PATCH v2 1/4] gpio: convert selectors of GENERIC_GPIO to GPIOLIB Alexandre Courbot
2013-04-16 9:34 ` Grant Likely
2013-04-16 9:34 ` Grant Likely
2013-04-08 18:32 ` [PATCH v2 2/4] gpio: remove GENERIC_GPIO config option Alexandre Courbot
2013-04-16 9:33 ` Grant Likely
2013-04-16 9:33 ` Grant Likely
2013-04-08 18:32 ` [PATCH v2 4/4] gpio: update gpio Chinese documentation Alexandre Courbot
2013-04-16 9:40 ` Grant Likely
2013-04-16 9:40 ` Grant Likely
2013-04-11 14:05 ` [PATCH v2 0/4] remove GENERIC_GPIO Vineet Gupta
2013-04-12 18:42 ` Alexandre Courbot
2013-04-15 7:43 ` Christian Ruppert
2013-04-16 2:27 ` Alex Courbot
2013-04-16 7:34 ` Christian Ruppert
2013-04-16 9:01 ` Alex Courbot [this message]
2013-04-16 9:32 ` Grant Likely
2013-04-16 9:32 ` Grant Likely
2013-04-16 9:45 ` Grant Likely
2013-04-16 22:11 ` Alexandre Courbot
2013-04-16 22:11 ` Alexandre Courbot
[not found] ` <1365445950-5736-4-git-send-email-gnurou@gmail.com>
2013-04-16 9:39 ` [PATCH v2 3/4] gpio: rename CONFIG_GPIOLIB to CONFIG_GPIO Grant Likely
2013-04-16 9:39 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D1359.2080609@nvidia.com \
--to=acourbot@nvidia.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=christian.ruppert@abilis.com \
--cc=gnurou@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=pierrick.hascoet@abilis.com \
--cc=sascha.leuenberger@abilis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox