From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched Date: Tue, 16 Apr 2013 17:02:08 +0100 Message-ID: <516D7600.4080002@imgtec.com> References: <1364973141-16354-1-git-send-email-vgupta@synopsys.com> <515BD6B8.1020607@synopsys.com> <515C5652.8070705@wwwdotorg.org> <515D0FFB.4030803@synopsys.com> <515DBA0E.6000604@wwwdotorg.org> <51642158.3070205@synopsys.com> <5167BA67.5080403@synopsys.com> <5168822C.6040303@wwwdotorg.org> <516D7405.3060202@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <516D7405.3060202@imgtec.com> Sender: linux-kbuild-owner@vger.kernel.org To: Vineet Gupta Cc: Stephen Warren , "linux-arch@vger.kernel.org" , linux-kernel@vger.kernel.org, Michal Marek , Stephen Warren , Grant Likely , linux-kbuild@vger.kernel.org, Sam Ravnborg List-Id: linux-arch.vger.kernel.org On 16/04/13 16:53, James Hogan wrote: > On 12/04/13 22:52, Stephen Warren wrote: >> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S > > Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, > since it'll have quotes around it, so you may instead need: > .SECONDARY: $(obj)/$(patsubst "%",%,$(builtindtb-y)).dtb.S > > (at least that's what's required for the metag equivalent) > >> + >> dtbs: $(addprefix $(obj)/, $(builtindtb-y).dtb) > > You might find the same thing here too. Also, I think you probably now want *.dtb.S added to clean-files, otherwise they won't get removed by make clean. Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from multi.imgtec.com ([194.200.65.239]:28263 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935550Ab3DPQCN (ORCPT ); Tue, 16 Apr 2013 12:02:13 -0400 Message-ID: <516D7600.4080002@imgtec.com> Date: Tue, 16 Apr 2013 17:02:08 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched References: <1364973141-16354-1-git-send-email-vgupta@synopsys.com> <515BD6B8.1020607@synopsys.com> <515C5652.8070705@wwwdotorg.org> <515D0FFB.4030803@synopsys.com> <515DBA0E.6000604@wwwdotorg.org> <51642158.3070205@synopsys.com> <5167BA67.5080403@synopsys.com> <5168822C.6040303@wwwdotorg.org> <516D7405.3060202@imgtec.com> In-Reply-To: <516D7405.3060202@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Vineet Gupta Cc: Stephen Warren , "linux-arch@vger.kernel.org" , linux-kernel@vger.kernel.org, Michal Marek , Stephen Warren , Grant Likely , linux-kbuild@vger.kernel.org, Sam Ravnborg Message-ID: <20130416160208.851M39wl0meLZR5linW1-7vM0UrRiY_akC8BhLjUvf8@z> On 16/04/13 16:53, James Hogan wrote: > On 12/04/13 22:52, Stephen Warren wrote: >> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S > > Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, > since it'll have quotes around it, so you may instead need: > .SECONDARY: $(obj)/$(patsubst "%",%,$(builtindtb-y)).dtb.S > > (at least that's what's required for the metag equivalent) > >> + >> dtbs: $(addprefix $(obj)/, $(builtindtb-y).dtb) > > You might find the same thing here too. Also, I think you probably now want *.dtb.S added to clean-files, otherwise they won't get removed by make clean. Cheers James