From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet Gupta Subject: Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched Date: Wed, 17 Apr 2013 09:43:29 +0530 Message-ID: <516E2169.4020007@synopsys.com> References: <1364973141-16354-1-git-send-email-vgupta@synopsys.com> <515BD6B8.1020607@synopsys.com> <515C5652.8070705@wwwdotorg.org> <515D0FFB.4030803@synopsys.com> <515DBA0E.6000604@wwwdotorg.org> <51642158.3070205@synopsys.com> <5167BA67.5080403@synopsys.com> <5168822C.6040303@wwwdotorg.org> <516D7405.3060202@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from alvesta.synopsys.com ([198.182.60.77]:38015 "EHLO alvesta.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749Ab3DQENr (ORCPT ); Wed, 17 Apr 2013 00:13:47 -0400 In-Reply-To: <516D7405.3060202@imgtec.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: James Hogan Cc: Stephen Warren , "linux-arch@vger.kernel.org" , linux-kernel@vger.kernel.org, Michal Marek , Stephen Warren , Grant Likely , linux-kbuild@vger.kernel.org, Sam Ravnborg Hi James, On 04/16/2013 09:23 PM, James Hogan wrote: > On 12/04/13 22:52, Stephen Warren wrote: >> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S > Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME, > since it'll have quotes around it, so you may instead need: > .SECONDARY: $(obj)/$(patsubst "%",%,$(builtindtb-y)).dtb.S > > (at least that's what's required for the metag equivalent) > >> + >> dtbs: $(addprefix $(obj)/, $(builtindtb-y).dtb) > You might find the same thing here too. Actually in my Makefile, the quotes are stripped off in the very beginning to avoid duplicating it in every place. ifneq ($(CONFIG_ARC_BUILTIN_DTB_NAME),"") builtindtb-y := $(patsubst "%",%,$(CONFIG_ARC_BUILTIN_DTB_NAME)) endif .... Thus both the above are not required - redundant if at all. -Vineet