From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init() Date: Wed, 08 May 2013 23:29:36 +0400 Message-ID: <518AA7A0.1020702@cogentembedded.com> References: <1368028298-7401-1-git-send-email-jiang.liu@huawei.com> <1368028298-7401-21-git-send-email-jiang.liu@huawei.com> <518A7CC0.1010606@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <518A7CC0.1010606@cogentembedded.com> Sender: owner-linux-mm@kvack.org To: Jiang Liu Cc: Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Yoshinori Sato , Geert Uytterhoeven List-Id: linux-arch.vger.kernel.org Hello. On 05/08/2013 08:26 PM, Sergei Shtylyov wrote: > >> Prepare for removing num_physpages and simplify mem_init(). > >> Signed-off-by: Jiang Liu >> Cc: Yoshinori Sato >> Cc: Geert Uytterhoeven >> Cc: linux-kernel@vger.kernel.org >> --- >> arch/h8300/mm/init.c | 34 ++++++++-------------------------- >> 1 file changed, 8 insertions(+), 26 deletions(-) > >> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c >> index 22fd869..0088f3a 100644 >> --- a/arch/h8300/mm/init.c >> +++ b/arch/h8300/mm/init.c >> @@ -121,40 +121,22 @@ void __init paging_init(void) >> >> void __init mem_init(void) >> { >> - int codek = 0, datak = 0, initk = 0; >> - /* DAVIDM look at setup memory map generically with reserved >> area */ >> - unsigned long tmp; >> - extern unsigned long _ramend, _ramstart; >> - unsigned long len = &_ramend - &_ramstart; >> - unsigned long start_mem = memory_start; /* DAVIDM - these must >> start at end of kernel */ >> - unsigned long end_mem = memory_end; /* DAVIDM - this must not >> include kernel stack at top */ >> + unsigned long codesize = _etext - _stext; >> >> #ifdef DEBUG >> - printk(KERN_DEBUG "Mem_init: start=%lx, end=%lx\n", start_mem, >> end_mem); >> + pr_debug("Mem_init: start=%lx, end=%lx\n", memory_start, >> memory_end); >> #endif > > pr_debug() only prints something if DEBUG is #define'd, so you can > drop the #ifdef here. Although, not necessarily: it also supports CONFIG_DYNAMIC_DEBUG -- look at how pr_debug() is defined. So this doesn't seem to be an equivalent change, and I suggest not doing it at all. WBR, Sergei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f171.google.com ([209.85.217.171]:47124 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653Ab3EHT3f (ORCPT ); Wed, 8 May 2013 15:29:35 -0400 Received: by mail-lb0-f171.google.com with SMTP id u10so2302656lbi.16 for ; Wed, 08 May 2013 12:29:34 -0700 (PDT) Message-ID: <518AA7A0.1020702@cogentembedded.com> Date: Wed, 08 May 2013 23:29:36 +0400 From: Sergei Shtylyov MIME-Version: 1.0 Subject: Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init() References: <1368028298-7401-1-git-send-email-jiang.liu@huawei.com> <1368028298-7401-21-git-send-email-jiang.liu@huawei.com> <518A7CC0.1010606@cogentembedded.com> In-Reply-To: <518A7CC0.1010606@cogentembedded.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jiang Liu Cc: Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Yoshinori Sato , Geert Uytterhoeven Message-ID: <20130508192936.sH8aYLTtsqtDb_qkBt13pQXRrmHybBImAUfg5-XnXsQ@z> Hello. On 05/08/2013 08:26 PM, Sergei Shtylyov wrote: > >> Prepare for removing num_physpages and simplify mem_init(). > >> Signed-off-by: Jiang Liu >> Cc: Yoshinori Sato >> Cc: Geert Uytterhoeven >> Cc: linux-kernel@vger.kernel.org >> --- >> arch/h8300/mm/init.c | 34 ++++++++-------------------------- >> 1 file changed, 8 insertions(+), 26 deletions(-) > >> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c >> index 22fd869..0088f3a 100644 >> --- a/arch/h8300/mm/init.c >> +++ b/arch/h8300/mm/init.c >> @@ -121,40 +121,22 @@ void __init paging_init(void) >> >> void __init mem_init(void) >> { >> - int codek = 0, datak = 0, initk = 0; >> - /* DAVIDM look at setup memory map generically with reserved >> area */ >> - unsigned long tmp; >> - extern unsigned long _ramend, _ramstart; >> - unsigned long len = &_ramend - &_ramstart; >> - unsigned long start_mem = memory_start; /* DAVIDM - these must >> start at end of kernel */ >> - unsigned long end_mem = memory_end; /* DAVIDM - this must not >> include kernel stack at top */ >> + unsigned long codesize = _etext - _stext; >> >> #ifdef DEBUG >> - printk(KERN_DEBUG "Mem_init: start=%lx, end=%lx\n", start_mem, >> end_mem); >> + pr_debug("Mem_init: start=%lx, end=%lx\n", memory_start, >> memory_end); >> #endif > > pr_debug() only prints something if DEBUG is #define'd, so you can > drop the #ifdef here. Although, not necessarily: it also supports CONFIG_DYNAMIC_DEBUG -- look at how pr_debug() is defined. So this doesn't seem to be an equivalent change, and I suggest not doing it at all. WBR, Sergei