From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cody P Schafer Subject: Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem_init() Date: Wed, 08 May 2013 16:35:22 -0700 Message-ID: <518AE13A.2060204@linux.vnet.ibm.com> References: <1368028298-7401-1-git-send-email-jiang.liu@huawei.com> <1368028298-7401-21-git-send-email-jiang.liu@huawei.com> <518A7CC0.1010606@cogentembedded.com> <518AA7A0.1020702@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from e8.ny.us.ibm.com ([32.97.182.138]:37289 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997Ab3EHXfe (ORCPT ); Wed, 8 May 2013 19:35:34 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 May 2013 19:35:30 -0400 In-Reply-To: <518AA7A0.1020702@cogentembedded.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Sergei Shtylyov Cc: Jiang Liu , Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Yoshinori Sato , Geert Uytterhoeven On 05/08/2013 12:29 PM, Sergei Shtylyov wrote: > > Although, not necessarily: it also supports CONFIG_DYNAMIC_DEBUG -- > look at how pr_debug() is defined. > So this doesn't seem to be an equivalent change, and I suggest not doing > it at all. > > WBR, Sergei pr_devel() should get the same behavior: no code emitted unless debug is defined, if it is, output at KERN_DEBUG level.