From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liu Jiang Subject: Re: [PATCH v6, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ Date: Fri, 17 May 2013 23:28:21 +0800 Message-ID: <51964C95.2010401@gmail.com> References: <1368293689-16410-17-git-send-email-jiang.liu@huawei.com> <1368293689-16410-1-git-send-email-jiang.liu@huawei.com> <15932.1368438005@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <15932.1368438005@warthog.procyon.org.uk> Sender: owner-linux-mm@kvack.org To: David Howells Cc: Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , Sergei Shtylyov , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Haavard Skinnemoen List-Id: linux-arch.vger.kernel.org On 05/13/2013 05:40 PM, David Howells wrote: > Jiang Liu wrote: > >> -#ifndef HZ >> +#ifndef __KERNEL__ >> + /* >> + * Technically, this is wrong, but some old apps still refer to it. >> + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK). >> + */ >> # define HZ 100 >> #endif > Better still, use asm-generic/param.h and uapi/asm-generic/param.h for AVR32 > instead. > > David > Hi David, Great idea! Will use generic param.h for AVR32. Regards! Gerry -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f177.google.com ([209.85.192.177]:38800 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab3EQP22 (ORCPT ); Fri, 17 May 2013 11:28:28 -0400 Message-ID: <51964C95.2010401@gmail.com> Date: Fri, 17 May 2013 23:28:21 +0800 From: Liu Jiang MIME-Version: 1.0 Subject: Re: [PATCH v6, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ References: <1368293689-16410-17-git-send-email-jiang.liu@huawei.com> <1368293689-16410-1-git-send-email-jiang.liu@huawei.com> <15932.1368438005@warthog.procyon.org.uk> In-Reply-To: <15932.1368438005@warthog.procyon.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Howells Cc: Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , Sergei Shtylyov , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Haavard Skinnemoen Message-ID: <20130517152821.fcd6yAyJ7ifCtM5AZPrcm6eOBe130CDo9ehwho58BsE@z> On 05/13/2013 05:40 PM, David Howells wrote: > Jiang Liu wrote: > >> -#ifndef HZ >> +#ifndef __KERNEL__ >> + /* >> + * Technically, this is wrong, but some old apps still refer to it. >> + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK). >> + */ >> # define HZ 100 >> #endif > Better still, use asm-generic/param.h and uapi/asm-generic/param.h for AVR32 > instead. > > David > Hi David, Great idea! Will use generic param.h for AVR32. Regards! Gerry