From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] arch: blackfin: kernel: using strlcpy instead of strncpy Date: Mon, 27 May 2013 09:50:56 +0800 Message-ID: <51A2BC00.2050906@asianux.com> References: <51A1B419.5000704@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from intranet.asianux.com ([58.214.24.6]:48243 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755718Ab3E0Bvt (ORCPT ); Sun, 26 May 2013 21:51:49 -0400 In-Reply-To: <51A1B419.5000704@asianux.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mike Frysinger , Paul Mundt , realmz paranoid , Geert Uytterhoeven , monstr@monstr.eu, "uclinux-dist-devel@blackfin.uclinux.org" , "linux-kernel@vger.kernel.org" , Linux-Arch On 05/26/2013 03:04 PM, Chen Gang wrote: > > For NULL terminated string, need always be sure of ended by zero. > > 'command_line' is a static variable which will be initialized > automatically, and cmdline_init() is __init function, so need not > initialize it again, can just use strlcpy instead of strncpy. > The 2nd paragraph comment is redundent, need delete. I will send patch v2. > > Signed-off-by: Chen Gang > --- > arch/blackfin/kernel/setup.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c > index 107b306..c731ec7 100644 > --- a/arch/blackfin/kernel/setup.c > +++ b/arch/blackfin/kernel/setup.c > @@ -1458,5 +1458,5 @@ void __init cmdline_init(const char *r0) > { > early_shadow_stamp(); > if (r0) > - strncpy(command_line, r0, COMMAND_LINE_SIZE); > + strlcpy(command_line, r0, COMMAND_LINE_SIZE); > } > -- Chen Gang Asianux Corporation