* [PATCH] arch: xtensa: include: asm: compiling issue, need cmpxchg64() defined.
@ 2013-05-27 11:57 Chen Gang
2013-05-27 16:19 ` Max Filippov
0 siblings, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-05-27 11:57 UTC (permalink / raw)
To: chris, jcmvbkbc; +Cc: linux-xtensa, linux-kernel@vger.kernel.org, Linux-Arch
When compiling with 'allmodconfig', some of drivers need cmpxchg64(),
xtensa does not supply 64-bit implementation for 'xchg', so use the
'generic' implementation.
e.g. (for next-20130527 tree):
drivers/block/blockconsole.c:164:2: error: implicit declaration of function ‘cmpxchg64’ [-Werror=implicit-function-declaration]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/xtensa/include/asm/cmpxchg.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/xtensa/include/asm/cmpxchg.h b/arch/xtensa/include/asm/cmpxchg.h
index d9ab131..370b26f 100644
--- a/arch/xtensa/include/asm/cmpxchg.h
+++ b/arch/xtensa/include/asm/cmpxchg.h
@@ -93,6 +93,7 @@ static inline unsigned long __cmpxchg_local(volatile void *ptr,
((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), (unsigned long)(o),\
(unsigned long)(n), sizeof(*(ptr))))
#define cmpxchg64_local(ptr, o, n) __cmpxchg64_local_generic((ptr), (o), (n))
+#define cmpxchg64(ptr, o, n) cmpxchg64_local((ptr), (o), (n))
/*
* xchg_u32
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arch: xtensa: include: asm: compiling issue, need cmpxchg64() defined.
2013-05-27 11:57 [PATCH] arch: xtensa: include: asm: compiling issue, need cmpxchg64() defined Chen Gang
@ 2013-05-27 16:19 ` Max Filippov
2013-05-27 16:19 ` Max Filippov
2013-05-28 4:57 ` Chen Gang
0 siblings, 2 replies; 4+ messages in thread
From: Max Filippov @ 2013-05-27 16:19 UTC (permalink / raw)
To: Chen Gang; +Cc: chris, linux-xtensa, linux-kernel@vger.kernel.org, Linux-Arch
On Mon, May 27, 2013 at 3:57 PM, Chen Gang <gang.chen@asianux.com> wrote:
>
> When compiling with 'allmodconfig', some of drivers need cmpxchg64(),
> xtensa does not supply 64-bit implementation for 'xchg', so use the
> 'generic' implementation.
>
> e.g. (for next-20130527 tree):
> drivers/block/blockconsole.c:164:2: error: implicit declaration of function ‘cmpxchg64’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/xtensa/include/asm/cmpxchg.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Taken to the xtensa-fixes tree. Thanks.
-- Max
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arch: xtensa: include: asm: compiling issue, need cmpxchg64() defined.
2013-05-27 16:19 ` Max Filippov
@ 2013-05-27 16:19 ` Max Filippov
2013-05-28 4:57 ` Chen Gang
1 sibling, 0 replies; 4+ messages in thread
From: Max Filippov @ 2013-05-27 16:19 UTC (permalink / raw)
To: Chen Gang; +Cc: chris, linux-xtensa, linux-kernel@vger.kernel.org, Linux-Arch
On Mon, May 27, 2013 at 3:57 PM, Chen Gang <gang.chen@asianux.com> wrote:
>
> When compiling with 'allmodconfig', some of drivers need cmpxchg64(),
> xtensa does not supply 64-bit implementation for 'xchg', so use the
> 'generic' implementation.
>
> e.g. (for next-20130527 tree):
> drivers/block/blockconsole.c:164:2: error: implicit declaration of function ‘cmpxchg64’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/xtensa/include/asm/cmpxchg.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Taken to the xtensa-fixes tree. Thanks.
-- Max
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arch: xtensa: include: asm: compiling issue, need cmpxchg64() defined.
2013-05-27 16:19 ` Max Filippov
2013-05-27 16:19 ` Max Filippov
@ 2013-05-28 4:57 ` Chen Gang
1 sibling, 0 replies; 4+ messages in thread
From: Chen Gang @ 2013-05-28 4:57 UTC (permalink / raw)
To: Max Filippov
Cc: chris, linux-xtensa, linux-kernel@vger.kernel.org, Linux-Arch
On 05/28/2013 12:19 AM, Max Filippov wrote:
> On Mon, May 27, 2013 at 3:57 PM, Chen Gang <gang.chen@asianux.com> wrote:
>>
>> When compiling with 'allmodconfig', some of drivers need cmpxchg64(),
>> xtensa does not supply 64-bit implementation for 'xchg', so use the
>> 'generic' implementation.
>>
>> e.g. (for next-20130527 tree):
>> drivers/block/blockconsole.c:164:2: error: implicit declaration of function ‘cmpxchg64’ [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>> arch/xtensa/include/asm/cmpxchg.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Taken to the xtensa-fixes tree. Thanks.
>
Thank you too.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-28 4:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-27 11:57 [PATCH] arch: xtensa: include: asm: compiling issue, need cmpxchg64() defined Chen Gang
2013-05-27 16:19 ` Max Filippov
2013-05-27 16:19 ` Max Filippov
2013-05-28 4:57 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox