* [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero.
@ 2013-05-30 6:25 Chen Gang
2013-05-30 7:09 ` Andreas Schwab
0 siblings, 1 reply; 10+ messages in thread
From: Chen Gang @ 2013-05-30 6:25 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-m68k, linux-kernel@vger.kernel.org, Linux-Arch
'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
author wanted to check the highest bit whether set.
So need type cast form 'unsigned long' to 'long'.
The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/m68k/math-emu/fp_arith.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
index 08f286d..ef013c5 100644
--- a/arch/m68k/math-emu/fp_arith.c
+++ b/arch/m68k/math-emu/fp_arith.c
@@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
return;
break;
case 0x401e:
- if (!(oldmant.m32[1] >= 0))
+ if (!((long)oldmant.m32[1] >= 0))
return;
if (oldmant.m32[0] & 1)
break;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero.
2013-05-30 6:25 [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero Chen Gang
@ 2013-05-30 7:09 ` Andreas Schwab
2013-05-30 8:08 ` Chen Gang
2013-05-30 8:21 ` [PATCH v2] " Chen Gang
0 siblings, 2 replies; 10+ messages in thread
From: Andreas Schwab @ 2013-05-30 7:09 UTC (permalink / raw)
To: Chen Gang
Cc: Geert Uytterhoeven, linux-m68k, linux-kernel@vger.kernel.org,
Linux-Arch
Chen Gang <gang.chen@asianux.com> writes:
> 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
> author wanted to check the highest bit whether set.
>
> So need type cast form 'unsigned long' to 'long'.
Better to make the bit test explicit, since it is not a sign bit.
> diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
> index 08f286d..ef013c5 100644
> --- a/arch/m68k/math-emu/fp_arith.c
> +++ b/arch/m68k/math-emu/fp_arith.c
> @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
> return;
> break;
> case 0x401e:
> - if (!(oldmant.m32[1] >= 0))
> + if (!((long)oldmant.m32[1] >= 0))
if (oldmant.m32[1] & 0x80000000)
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero.
2013-05-30 7:09 ` Andreas Schwab
@ 2013-05-30 8:08 ` Chen Gang
2013-05-30 8:08 ` Chen Gang
2013-05-30 8:21 ` [PATCH v2] " Chen Gang
1 sibling, 1 reply; 10+ messages in thread
From: Chen Gang @ 2013-05-30 8:08 UTC (permalink / raw)
To: Andreas Schwab
Cc: Geert Uytterhoeven, linux-m68k, linux-kernel@vger.kernel.org,
Linux-Arch
On 05/30/2013 03:09 PM, Andreas Schwab wrote:
> Chen Gang <gang.chen@asianux.com> writes:
>
>> > 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
>> > author wanted to check the highest bit whether set.
>> >
>> > So need type cast form 'unsigned long' to 'long'.
> Better to make the bit test explicit, since it is not a sign bit.
>
That sounds good.
>> > diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
>> > index 08f286d..ef013c5 100644
>> > --- a/arch/m68k/math-emu/fp_arith.c
>> > +++ b/arch/m68k/math-emu/fp_arith.c
>> > @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
>> > return;
>> > break;
>> > case 0x401e:
>> > - if (!(oldmant.m32[1] >= 0))
>> > + if (!((long)oldmant.m32[1] >= 0))
> if (oldmant.m32[1] & 0x80000000)
OK, I will send patch v2.
Thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero.
2013-05-30 8:08 ` Chen Gang
@ 2013-05-30 8:08 ` Chen Gang
0 siblings, 0 replies; 10+ messages in thread
From: Chen Gang @ 2013-05-30 8:08 UTC (permalink / raw)
To: Andreas Schwab
Cc: Geert Uytterhoeven, linux-m68k, linux-kernel@vger.kernel.org,
Linux-Arch
On 05/30/2013 03:09 PM, Andreas Schwab wrote:
> Chen Gang <gang.chen@asianux.com> writes:
>
>> > 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
>> > author wanted to check the highest bit whether set.
>> >
>> > So need type cast form 'unsigned long' to 'long'.
> Better to make the bit test explicit, since it is not a sign bit.
>
That sounds good.
>> > diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
>> > index 08f286d..ef013c5 100644
>> > --- a/arch/m68k/math-emu/fp_arith.c
>> > +++ b/arch/m68k/math-emu/fp_arith.c
>> > @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
>> > return;
>> > break;
>> > case 0x401e:
>> > - if (!(oldmant.m32[1] >= 0))
>> > + if (!((long)oldmant.m32[1] >= 0))
> if (oldmant.m32[1] & 0x80000000)
OK, I will send patch v2.
Thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero
2013-05-30 7:09 ` Andreas Schwab
2013-05-30 8:08 ` Chen Gang
@ 2013-05-30 8:21 ` Chen Gang
2013-05-30 8:21 ` Chen Gang
2013-05-31 9:12 ` Geert Uytterhoeven
1 sibling, 2 replies; 10+ messages in thread
From: Chen Gang @ 2013-05-30 8:21 UTC (permalink / raw)
To: Andreas Schwab, Geert Uytterhoeven
Cc: linux-m68k, linux-kernel@vger.kernel.org, Linux-Arch
'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
author wanted to check the highest bit whether set.
So need make the bit test explicit (which is better than type cast form
'unsigned long' to 'long').
The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/m68k/math-emu/fp_arith.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
index 08f286d..239eb19 100644
--- a/arch/m68k/math-emu/fp_arith.c
+++ b/arch/m68k/math-emu/fp_arith.c
@@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
return;
break;
case 0x401e:
- if (!(oldmant.m32[1] >= 0))
+ if (oldmant.m32[1] & 0x80000000)
return;
if (oldmant.m32[0] & 1)
break;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero
2013-05-30 8:21 ` [PATCH v2] " Chen Gang
@ 2013-05-30 8:21 ` Chen Gang
2013-05-31 9:12 ` Geert Uytterhoeven
1 sibling, 0 replies; 10+ messages in thread
From: Chen Gang @ 2013-05-30 8:21 UTC (permalink / raw)
To: Andreas Schwab, Geert Uytterhoeven
Cc: linux-m68k, linux-kernel@vger.kernel.org, Linux-Arch
'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
author wanted to check the highest bit whether set.
So need make the bit test explicit (which is better than type cast form
'unsigned long' to 'long').
The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/m68k/math-emu/fp_arith.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
index 08f286d..239eb19 100644
--- a/arch/m68k/math-emu/fp_arith.c
+++ b/arch/m68k/math-emu/fp_arith.c
@@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
return;
break;
case 0x401e:
- if (!(oldmant.m32[1] >= 0))
+ if (oldmant.m32[1] & 0x80000000)
return;
if (oldmant.m32[0] & 1)
break;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero
2013-05-30 8:21 ` [PATCH v2] " Chen Gang
2013-05-30 8:21 ` Chen Gang
@ 2013-05-31 9:12 ` Geert Uytterhoeven
2013-06-03 9:10 ` Chen Gang
1 sibling, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2013-05-31 9:12 UTC (permalink / raw)
To: Chen Gang
Cc: Andreas Schwab, linux-m68k, linux-kernel@vger.kernel.org,
Linux-Arch
On Thu, May 30, 2013 at 10:21 AM, Chen Gang <gang.chen@asianux.com> wrote:
> 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
> author wanted to check the highest bit whether set.
>
> So need make the bit test explicit (which is better than type cast form
> 'unsigned long' to 'long').
>
> The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
> arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Thanks, applied and queued for 3.11!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero
2013-05-31 9:12 ` Geert Uytterhoeven
@ 2013-06-03 9:10 ` Chen Gang
2013-06-03 9:13 ` Geert Uytterhoeven
0 siblings, 1 reply; 10+ messages in thread
From: Chen Gang @ 2013-06-03 9:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andreas Schwab, linux-m68k, linux-kernel@vger.kernel.org,
Linux-Arch
On 05/31/2013 05:12 PM, Geert Uytterhoeven wrote:
> On Thu, May 30, 2013 at 10:21 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
>> author wanted to check the highest bit whether set.
>>
>> So need make the bit test explicit (which is better than type cast form
>> 'unsigned long' to 'long').
>>
>> The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
>> arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Thanks, applied and queued for 3.11!
>
Thank you too, and pardon: what is '3.11' ? :-)
Thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero
2013-06-03 9:10 ` Chen Gang
@ 2013-06-03 9:13 ` Geert Uytterhoeven
2013-06-03 9:22 ` Chen Gang
0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2013-06-03 9:13 UTC (permalink / raw)
To: Chen Gang
Cc: Andreas Schwab, linux-m68k, linux-kernel@vger.kernel.org,
Linux-Arch
On Mon, Jun 3, 2013 at 11:10 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> Thanks, applied and queued for 3.11!
>>
>
> Thank you too, and pardon: what is '3.11' ? :-)
Linux v3.11.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero
2013-06-03 9:13 ` Geert Uytterhoeven
@ 2013-06-03 9:22 ` Chen Gang
0 siblings, 0 replies; 10+ messages in thread
From: Chen Gang @ 2013-06-03 9:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andreas Schwab, linux-m68k, linux-kernel@vger.kernel.org,
Linux-Arch
On 06/03/2013 05:13 PM, Geert Uytterhoeven wrote:
> On Mon, Jun 3, 2013 at 11:10 AM, Chen Gang <gang.chen@asianux.com> wrote:
>>> >> Thanks, applied and queued for 3.11!
>>> >>
>> >
>> > Thank you too, and pardon: what is '3.11' ? :-)
> Linux v3.11.
OK, thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-06-03 9:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 6:25 [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero Chen Gang
2013-05-30 7:09 ` Andreas Schwab
2013-05-30 8:08 ` Chen Gang
2013-05-30 8:08 ` Chen Gang
2013-05-30 8:21 ` [PATCH v2] " Chen Gang
2013-05-30 8:21 ` Chen Gang
2013-05-31 9:12 ` Geert Uytterhoeven
2013-06-03 9:10 ` Chen Gang
2013-06-03 9:13 ` Geert Uytterhoeven
2013-06-03 9:22 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).