* Re: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().
[not found] ` <519B425D.4030806@asianux.com>
@ 2013-05-27 10:02 ` Chen Gang
2013-06-08 4:37 ` Chen Gang
0 siblings, 1 reply; 6+ messages in thread
From: Chen Gang @ 2013-05-27 10:02 UTC (permalink / raw)
To: Will Deacon, Marc Zyngier
Cc: Catalin Marinas, Santosh Shilimkar, Tony Lindgren,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-Arch
Hello Maintainers:
Please help check this patch whether OK, when you have time.
Thanks.
On 05/21/2013 05:46 PM, Chen Gang wrote:
>
> Under arm64, we will calibrate the delay loop statically using a known
> timer frequency, so delete read_current_timer(), or it will cause
> compiling issue with allmodconfig.
>
> The related error:
> ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined!
> ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined!
> ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined!
> ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined!
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm64/include/asm/timex.h | 6 +++---
> arch/arm64/kernel/time.c | 6 ------
> 2 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/include/asm/timex.h b/arch/arm64/include/asm/timex.h
> index b24a31a..81a076e 100644
> --- a/arch/arm64/include/asm/timex.h
> +++ b/arch/arm64/include/asm/timex.h
> @@ -16,14 +16,14 @@
> #ifndef __ASM_TIMEX_H
> #define __ASM_TIMEX_H
>
> +#include <asm/arch_timer.h>
> +
> /*
> * Use the current timer as a cycle counter since this is what we use for
> * the delay loop.
> */
> -#define get_cycles() ({ cycles_t c; read_current_timer(&c); c; })
> +#define get_cycles() arch_counter_get_cntvct()
>
> #include <asm-generic/timex.h>
>
> -#define ARCH_HAS_READ_CURRENT_TIMER
> -
> #endif
> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
> index a551f88..03dc371 100644
> --- a/arch/arm64/kernel/time.c
> +++ b/arch/arm64/kernel/time.c
> @@ -68,12 +68,6 @@ unsigned long long notrace sched_clock(void)
> return arch_timer_read_counter() * sched_clock_mult;
> }
>
> -int read_current_timer(unsigned long *timer_value)
> -{
> - *timer_value = arch_timer_read_counter();
> - return 0;
> -}
> -
> void __init time_init(void)
> {
> u32 arch_timer_rate;
>
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().
2013-05-27 10:02 ` [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer() Chen Gang
@ 2013-06-08 4:37 ` Chen Gang
2013-06-10 8:57 ` Will Deacon
2013-06-10 8:57 ` Marc Zyngier
0 siblings, 2 replies; 6+ messages in thread
From: Chen Gang @ 2013-06-08 4:37 UTC (permalink / raw)
To: Will Deacon, Marc Zyngier
Cc: Catalin Marinas, Santosh Shilimkar, Tony Lindgren,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-Arch
Hello Maintainers:
Please help check it, when you have time.
Thanks.
On 05/27/2013 06:02 PM, Chen Gang wrote:
> Hello Maintainers:
>
> Please help check this patch whether OK, when you have time.
>
> Thanks.
>
> On 05/21/2013 05:46 PM, Chen Gang wrote:
>>
>> Under arm64, we will calibrate the delay loop statically using a known
>> timer frequency, so delete read_current_timer(), or it will cause
>> compiling issue with allmodconfig.
>>
>> The related error:
>> ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined!
>> ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined!
>> ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined!
>> ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined!
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>> arch/arm64/include/asm/timex.h | 6 +++---
>> arch/arm64/kernel/time.c | 6 ------
>> 2 files changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/timex.h b/arch/arm64/include/asm/timex.h
>> index b24a31a..81a076e 100644
>> --- a/arch/arm64/include/asm/timex.h
>> +++ b/arch/arm64/include/asm/timex.h
>> @@ -16,14 +16,14 @@
>> #ifndef __ASM_TIMEX_H
>> #define __ASM_TIMEX_H
>>
>> +#include <asm/arch_timer.h>
>> +
>> /*
>> * Use the current timer as a cycle counter since this is what we use for
>> * the delay loop.
>> */
>> -#define get_cycles() ({ cycles_t c; read_current_timer(&c); c; })
>> +#define get_cycles() arch_counter_get_cntvct()
>>
>> #include <asm-generic/timex.h>
>>
>> -#define ARCH_HAS_READ_CURRENT_TIMER
>> -
>> #endif
>> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
>> index a551f88..03dc371 100644
>> --- a/arch/arm64/kernel/time.c
>> +++ b/arch/arm64/kernel/time.c
>> @@ -68,12 +68,6 @@ unsigned long long notrace sched_clock(void)
>> return arch_timer_read_counter() * sched_clock_mult;
>> }
>>
>> -int read_current_timer(unsigned long *timer_value)
>> -{
>> - *timer_value = arch_timer_read_counter();
>> - return 0;
>> -}
>> -
>> void __init time_init(void)
>> {
>> u32 arch_timer_rate;
>>
>
>
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().
2013-06-08 4:37 ` Chen Gang
@ 2013-06-10 8:57 ` Will Deacon
2013-06-13 1:12 ` Chen Gang
2013-06-10 8:57 ` Marc Zyngier
1 sibling, 1 reply; 6+ messages in thread
From: Will Deacon @ 2013-06-10 8:57 UTC (permalink / raw)
To: Chen Gang
Cc: Marc Zyngier, Catalin Marinas, Santosh Shilimkar, Tony Lindgren,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-Arch
On Sat, Jun 08, 2013 at 05:37:30AM +0100, Chen Gang wrote:
> Hello Maintainers:
>
> Please help check it, when you have time.
[...]
> >> Under arm64, we will calibrate the delay loop statically using a known
> >> timer frequency, so delete read_current_timer(), or it will cause
> >> compiling issue with allmodconfig.
> >>
> >> The related error:
> >> ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined!
> >> ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined!
> >> ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined!
> >> ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined!
> >>
> >>
> >> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> >> ---
> >> arch/arm64/include/asm/timex.h | 6 +++---
> >> arch/arm64/kernel/time.c | 6 ------
> >> 2 files changed, 3 insertions(+), 9 deletions(-)
Looks ok to me. We'll take it for a spin and apply it if it doesn't catch
fire.
Will
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().
2013-06-08 4:37 ` Chen Gang
2013-06-10 8:57 ` Will Deacon
@ 2013-06-10 8:57 ` Marc Zyngier
2013-06-13 1:13 ` Chen Gang
1 sibling, 1 reply; 6+ messages in thread
From: Marc Zyngier @ 2013-06-10 8:57 UTC (permalink / raw)
To: Chen Gang
Cc: Will Deacon, Catalin Marinas, Santosh Shilimkar, Tony Lindgren,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-Arch
On 08/06/13 05:37, Chen Gang wrote:
> Hello Maintainers:
>
> Please help check it, when you have time.
>
> Thanks.
>
> On 05/27/2013 06:02 PM, Chen Gang wrote:
>> Hello Maintainers:
>>
>> Please help check this patch whether OK, when you have time.
>>
>> Thanks.
>>
>> On 05/21/2013 05:46 PM, Chen Gang wrote:
>>>
>>> Under arm64, we will calibrate the delay loop statically using a known
>>> timer frequency, so delete read_current_timer(), or it will cause
>>> compiling issue with allmodconfig.
>>>
>>> The related error:
>>> ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined!
>>> ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined!
>>> ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined!
>>> ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined!
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>> ---
>>> arch/arm64/include/asm/timex.h | 6 +++---
>>> arch/arm64/kernel/time.c | 6 ------
>>> 2 files changed, 3 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/arch/arm64/include/asm/timex.h b/arch/arm64/include/asm/timex.h
>>> index b24a31a..81a076e 100644
>>> --- a/arch/arm64/include/asm/timex.h
>>> +++ b/arch/arm64/include/asm/timex.h
>>> @@ -16,14 +16,14 @@
>>> #ifndef __ASM_TIMEX_H
>>> #define __ASM_TIMEX_H
>>>
>>> +#include <asm/arch_timer.h>
>>> +
>>> /*
>>> * Use the current timer as a cycle counter since this is what we use for
>>> * the delay loop.
>>> */
>>> -#define get_cycles() ({ cycles_t c; read_current_timer(&c); c; })
>>> +#define get_cycles() arch_counter_get_cntvct()
>>>
>>> #include <asm-generic/timex.h>
>>>
>>> -#define ARCH_HAS_READ_CURRENT_TIMER
>>> -
>>> #endif
>>> diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
>>> index a551f88..03dc371 100644
>>> --- a/arch/arm64/kernel/time.c
>>> +++ b/arch/arm64/kernel/time.c
>>> @@ -68,12 +68,6 @@ unsigned long long notrace sched_clock(void)
>>> return arch_timer_read_counter() * sched_clock_mult;
>>> }
>>>
>>> -int read_current_timer(unsigned long *timer_value)
>>> -{
>>> - *timer_value = arch_timer_read_counter();
>>> - return 0;
>>> -}
>>> -
>>> void __init time_init(void)
>>> {
>>> u32 arch_timer_rate;
Sorry for the delay replying. This looks good to me.
FWIW:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().
2013-06-10 8:57 ` Will Deacon
@ 2013-06-13 1:12 ` Chen Gang
0 siblings, 0 replies; 6+ messages in thread
From: Chen Gang @ 2013-06-13 1:12 UTC (permalink / raw)
To: Will Deacon
Cc: Marc Zyngier, Catalin Marinas, Santosh Shilimkar, Tony Lindgren,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-Arch
On 06/10/2013 04:57 PM, Will Deacon wrote:
> On Sat, Jun 08, 2013 at 05:37:30AM +0100, Chen Gang wrote:
>> > Hello Maintainers:
>> >
>> > Please help check it, when you have time.
> [...]
>
OK, thanks.
>>>> > >> Under arm64, we will calibrate the delay loop statically using a known
>>>> > >> timer frequency, so delete read_current_timer(), or it will cause
>>>> > >> compiling issue with allmodconfig.
>>>> > >>
>>>> > >> The related error:
>>>> > >> ERROR: "read_current_timer" [lib/rbtree_test.ko] undefined!
>>>> > >> ERROR: "read_current_timer" [lib/interval_tree_test.ko] undefined!
>>>> > >> ERROR: "read_current_timer" [fs/ext4/ext4.ko] undefined!
>>>> > >> ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined!
>>>> > >>
>>>> > >>
>>>> > >> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>>> > >> ---
>>>> > >> arch/arm64/include/asm/timex.h | 6 +++---
>>>> > >> arch/arm64/kernel/time.c | 6 ------
>>>> > >> 2 files changed, 3 insertions(+), 9 deletions(-)
> Looks ok to me. We'll take it for a spin and apply it if it doesn't catch
> fire.
Really need a carefully checking.
Thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer().
2013-06-10 8:57 ` Marc Zyngier
@ 2013-06-13 1:13 ` Chen Gang
0 siblings, 0 replies; 6+ messages in thread
From: Chen Gang @ 2013-06-13 1:13 UTC (permalink / raw)
To: Marc Zyngier
Cc: Will Deacon, Catalin Marinas, Santosh Shilimkar, Tony Lindgren,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Linux-Arch
On 06/10/2013 04:57 PM, Marc Zyngier wrote:
> Sorry for the delay replying. This looks good to me.
>
> FWIW:
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Thanks, also sorry for my delay replying.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-13 1:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5199C725.8050102@asianux.com>
[not found] ` <168084c28e8ba5124c05553e97463172@localhost>
[not found] ` <20130520095606.GH31359@mudshark.cambridge.arm.com>
[not found] ` <519AF2DC.2040200@asianux.com>
[not found] ` <20130521085325.GB10453@mudshark.cambridge.arm.com>
[not found] ` <519B425D.4030806@asianux.com>
2013-05-27 10:02 ` [PATCH v2] arm64: kernel: compiling issue, need delete read_current_timer() Chen Gang
2013-06-08 4:37 ` Chen Gang
2013-06-10 8:57 ` Will Deacon
2013-06-13 1:12 ` Chen Gang
2013-06-10 8:57 ` Marc Zyngier
2013-06-13 1:13 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).