[PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask()

[PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask()

[Chen Gang]

atomic_set_mask() has already have 'unsigned' type case, and
atomic_clear_mask() is the pair of atomic_set_mask().

So it also need 'unsigned' type case.


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/x86/include/asm/atomic.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
index 722aa3b..5b5cf52 100644
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -255,7 +255,7 @@ static inline void atomic_or_long(unsigned long *v1, unsigned long v2)
 /* These are x86-specific, used by some header files */
 #define atomic_clear_mask(mask, addr)				\
 	asm volatile(LOCK_PREFIX "andl %0,%1"			\
-		     : : "r" (~(mask)), "m" (*(addr)) : "memory")
+		     : : "r" (~(unsigned)(mask)), "m" (*(addr)) : "memory")
 
 #define atomic_set_mask(mask, addr)				\
 	asm volatile(LOCK_PREFIX "orl %0,%1"			\
-- 
1.7.7.6

[PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask()

[Chen Gang]

atomic_set_mask() has already have 'unsigned' type case, and
atomic_clear_mask() is the pair of atomic_set_mask().

So it also need 'unsigned' type case.


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/x86/include/asm/atomic.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
index 722aa3b..5b5cf52 100644
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -255,7 +255,7 @@ static inline void atomic_or_long(unsigned long *v1, unsigned long v2)
 /* These are x86-specific, used by some header files */
 #define atomic_clear_mask(mask, addr)				\
 	asm volatile(LOCK_PREFIX "andl %0,%1"			\
-		     : : "r" (~(mask)), "m" (*(addr)) : "memory")
+		     : : "r" (~(unsigned)(mask)), "m" (*(addr)) : "memory")
 
 #define atomic_set_mask(mask, addr)				\
 	asm volatile(LOCK_PREFIX "orl %0,%1"			\
-- 
1.7.7.6

Re: [PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask()

[H. Peter Anvin]

On 06/07/2013 11:30 PM, Chen Gang wrote:
> 
> atomic_set_mask() has already have 'unsigned' type case, and
> atomic_clear_mask() is the pair of atomic_set_mask().
> 
> So it also need 'unsigned' type case.
> 

Pray tell, in what situation does this matter?  The only reason I can
think of is if "mask" is actually a long...

	-hpa

Re: [PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask()

[Chen Gang]

On 06/08/2013 03:31 PM, H. Peter Anvin wrote:
> On 06/07/2013 11:30 PM, Chen Gang wrote:
>> > 
>> > atomic_set_mask() has already have 'unsigned' type case, and
>> > atomic_clear_mask() is the pair of atomic_set_mask().
>> > 
>> > So it also need 'unsigned' type case.
>> > 
> Pray tell, in what situation does this matter?  The only reason I can
> think of is if "mask" is actually a long...

Excuse me, in fact, I don't know whether it will cause issue. Since
atomic_set_mask() has done, I think atomic_clear_mask() also need it.

If atomic_clear_mask() do need it, the atomic_set_mask() do not need it
either, they are the pairs --> they will face the same situation.


Thanks.
-- 
Chen Gang

Asianux Corporation

Re: [PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask()

[Chen Gang]

On 06/08/2013 04:02 PM, Chen Gang wrote:
> On 06/08/2013 03:31 PM, H. Peter Anvin wrote:
>> > On 06/07/2013 11:30 PM, Chen Gang wrote:
>>>> >> > 
>>>> >> > atomic_set_mask() has already have 'unsigned' type case, and
>>>> >> > atomic_clear_mask() is the pair of atomic_set_mask().
>>>> >> > 
>>>> >> > So it also need 'unsigned' type case.
>>>> >> > 
>> > Pray tell, in what situation does this matter?  The only reason I can
>> > think of is if "mask" is actually a long...
> Excuse me, in fact, I don't know whether it will cause issue. Since
> atomic_set_mask() has done, I think atomic_clear_mask() also need it.
> 
> If atomic_clear_mask() do need it, the atomic_set_mask() do not need it
> either, they are the pairs --> they will face the same situation.

Oh, my typo, it should be "If atomic_clear_mask() do not need it, the
atomic_set_mask() do not need it either, the are face same situation".


Thanks.
-- 
Chen Gang

Asianux Corporation