From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v4 0/4] add mutex wait/wound/style style locks Date: Wed, 12 Jun 2013 09:43:46 +0200 Message-ID: <51B826B2.5000508@canonical.com> References: <20130528144420.4538.70725.stgit@patser> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130528144420.4538.70725.stgit@patser> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, peterz@infradead.org, x86@kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, robclark@gmail.com, rostedt@goodmis.org, tglx@linutronix.de, mingo@elte.hu, linux-media@vger.kernel.org List-Id: linux-arch.vger.kernel.org Op 28-05-13 16:48, Maarten Lankhorst schreef: > Version 4 already? > > Small api changes since v3: > - Remove ww_mutex_unlock_single and ww_mutex_lock_single. > - Rename ww_mutex_trylock_single to ww_mutex_trylock. > - Remove separate implementations of ww_mutex_lock_slow*, normal > functions can be used. Inline versions still exist for extra > debugging, and to annotate. > - Cleanup unneeded memory barriers, add comment to the remaining > smp_mb(). > > Thanks to Daniel Vetter, Rob Clark and Peter Zijlstra for their feedback. > --- > > Daniel Vetter (1): > mutex: w/w mutex slowpath debugging > > Maarten Lankhorst (3): > arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not. > mutex: add support for wound/wait style locks, v5 > mutex: Add ww tests to lib/locking-selftest.c. v4 > > > Documentation/ww-mutex-design.txt | 344 +++++++++++++++++++++++++++++++ > arch/ia64/include/asm/mutex.h | 10 - > arch/powerpc/include/asm/mutex.h | 10 - > arch/sh/include/asm/mutex-llsc.h | 4 > arch/x86/include/asm/mutex_32.h | 11 - > arch/x86/include/asm/mutex_64.h | 11 - > include/asm-generic/mutex-dec.h | 10 - > include/asm-generic/mutex-null.h | 2 > include/asm-generic/mutex-xchg.h | 10 - > include/linux/mutex-debug.h | 1 > include/linux/mutex.h | 363 +++++++++++++++++++++++++++++++++ > kernel/mutex.c | 384 ++++++++++++++++++++++++++++++++--- > lib/Kconfig.debug | 13 + > lib/debug_locks.c | 2 > lib/locking-selftest.c | 410 +++++++++++++++++++++++++++++++++++-- > 15 files changed, 1492 insertions(+), 93 deletions(-) > create mode 100644 Documentation/ww-mutex-design.txt > Bump, do you have any feedback peterz? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:42514 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755974Ab3FLHnt (ORCPT ); Wed, 12 Jun 2013 03:43:49 -0400 Message-ID: <51B826B2.5000508@canonical.com> Date: Wed, 12 Jun 2013 09:43:46 +0200 From: Maarten Lankhorst MIME-Version: 1.0 Subject: Re: [PATCH v4 0/4] add mutex wait/wound/style style locks References: <20130528144420.4538.70725.stgit@patser> In-Reply-To: <20130528144420.4538.70725.stgit@patser> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, peterz@infradead.org, x86@kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, robclark@gmail.com, rostedt@goodmis.org, tglx@linutronix.de, mingo@elte.hu, linux-media@vger.kernel.org Message-ID: <20130612074346.DNSMUlMswOCLcqtickB6TwS7WYnbiRSd2SKSWAYlEJY@z> Op 28-05-13 16:48, Maarten Lankhorst schreef: > Version 4 already? > > Small api changes since v3: > - Remove ww_mutex_unlock_single and ww_mutex_lock_single. > - Rename ww_mutex_trylock_single to ww_mutex_trylock. > - Remove separate implementations of ww_mutex_lock_slow*, normal > functions can be used. Inline versions still exist for extra > debugging, and to annotate. > - Cleanup unneeded memory barriers, add comment to the remaining > smp_mb(). > > Thanks to Daniel Vetter, Rob Clark and Peter Zijlstra for their feedback. > --- > > Daniel Vetter (1): > mutex: w/w mutex slowpath debugging > > Maarten Lankhorst (3): > arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not. > mutex: add support for wound/wait style locks, v5 > mutex: Add ww tests to lib/locking-selftest.c. v4 > > > Documentation/ww-mutex-design.txt | 344 +++++++++++++++++++++++++++++++ > arch/ia64/include/asm/mutex.h | 10 - > arch/powerpc/include/asm/mutex.h | 10 - > arch/sh/include/asm/mutex-llsc.h | 4 > arch/x86/include/asm/mutex_32.h | 11 - > arch/x86/include/asm/mutex_64.h | 11 - > include/asm-generic/mutex-dec.h | 10 - > include/asm-generic/mutex-null.h | 2 > include/asm-generic/mutex-xchg.h | 10 - > include/linux/mutex-debug.h | 1 > include/linux/mutex.h | 363 +++++++++++++++++++++++++++++++++ > kernel/mutex.c | 384 ++++++++++++++++++++++++++++++++--- > lib/Kconfig.debug | 13 + > lib/debug_locks.c | 2 > lib/locking-selftest.c | 410 +++++++++++++++++++++++++++++++++++-- > 15 files changed, 1492 insertions(+), 93 deletions(-) > create mode 100644 Documentation/ww-mutex-design.txt > Bump, do you have any feedback peterz?