linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler()
@ 2013-06-22  5:54 Chen Gang
  2013-06-24  8:47 ` Will Deacon
  2013-06-24  9:27 ` [PATCH v2] " Chen Gang
  0 siblings, 2 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-22  5:54 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Tony Lindgren, olof@lixom.net, Santosh Shilimkar,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Linux-Arch


If 'COMPAT' not defined, aarch32_break_handler() cannot pass compiling,
so need add '#ifdef' for it just like the header file has done.

The related make:

  make ARCH=arm64 randconfig
  make ARCH=arm64 menuconfig
  make ARCH=arm64 V=1 EXTRA_CFLAGS=-W

The related error:

  arch/arm64/kernel/debug-monitors.c:249:5: error: redefinition of ‘aarch32_break_handler’
  In file included from arch/arm64/kernel/debug-monitors.c:29:0:
  /root/linux-next/arch/arm64/include/asm/debug-monitors.h:89:12: note: previous definition of ‘aarch32_break_handler’ was here


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/arm64/kernel/debug-monitors.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
index 08018e3..ceedcd7 100644
--- a/arch/arm64/kernel/debug-monitors.c
+++ b/arch/arm64/kernel/debug-monitors.c
@@ -246,6 +246,7 @@ static int brk_handler(unsigned long addr, unsigned int esr,
 	return 0;
 }
 
+#ifdef CONFIG_COMPAT
 int aarch32_break_handler(struct pt_regs *regs)
 {
 	siginfo_t info;
@@ -285,6 +286,7 @@ int aarch32_break_handler(struct pt_regs *regs)
 	force_sig_info(SIGTRAP, &info, current);
 	return 0;
 }
+#endif
 
 static int __init debug_traps_init(void)
 {
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2013-06-25 15:54 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-22  5:54 [PATCH] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler() Chen Gang
2013-06-24  8:47 ` Will Deacon
2013-06-24  9:19   ` Chen Gang
2013-06-24  9:27 ` [PATCH v2] " Chen Gang
2013-06-24 10:06   ` [Suggestion] arch: arm64: xen: "ln -s" the paravirt.h from arm Chen Gang
2013-06-24 15:43     ` Stefano Stabellini
2013-06-24 16:50       ` Stefano Stabellini
2013-06-25  1:31         ` Chen Gang
2013-06-25 12:32           ` Stefano Stabellini
2013-06-25 13:25         ` Catalin Marinas
2013-06-25 15:54           ` Stefano Stabellini
2013-06-25 15:54             ` Stefano Stabellini
2013-06-24 10:14   ` [PATCH v2] arch: arm64: kernel: add '#ifdef CONFIG_COMPAT' for aarch32_break_handler() Will Deacon
2013-06-24 10:16     ` Chen Gang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).