linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arch: c6x: kernel: include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled.
@ 2013-06-25  1:58 Chen Gang
  2013-06-25  7:06 ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-06-25  1:58 UTC (permalink / raw)
  To: msalter, a-jacquiot
  Cc: jkc, linux-c6x-dev, linux-kernel@vger.kernel.org, Linux-Arch

Need include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled
(e.g allmodconfig).

The related error:
  arch/c6x/kernel/setup.c: In function ‘setup_arch’:
  arch/c6x/kernel/setup.c:442:2: error: ‘conswitchp’ undeclared (first use in this function)
  arch/c6x/kernel/setup.c:442:2: note: each undeclared identifier is reported only once for each function it appears in
  arch/c6x/kernel/setup.c:442:16: error: ‘dummy_con’ undeclared (first use in this function)

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/c6x/kernel/setup.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/c6x/kernel/setup.c b/arch/c6x/kernel/setup.c
index f4e72bd..1411141 100644
--- a/arch/c6x/kernel/setup.c
+++ b/arch/c6x/kernel/setup.c
@@ -26,6 +26,9 @@
 #include <linux/cpu.h>
 #include <linux/fs.h>
 #include <linux/of.h>
+#if defined(CONFIG_VT) && defined(CONFIG_DUMMY_CONSOLE)
+#include <linux/console.h>
+#endif
 
 
 #include <asm/sections.h>
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arch: c6x: kernel: include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled.
  2013-06-25  1:58 [PATCH] arch: c6x: kernel: include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled Chen Gang
@ 2013-06-25  7:06 ` Geert Uytterhoeven
  2013-06-25  7:34   ` Chen Gang
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2013-06-25  7:06 UTC (permalink / raw)
  To: Chen Gang, Tony Breeds
  Cc: Mark Salter, a-jacquiot@ti.com, jkc, linux-c6x-dev,
	linux-kernel@vger.kernel.org, Linux-Arch

On Tue, Jun 25, 2013 at 3:58 AM, Chen Gang <gang.chen@asianux.com> wrote:
> Need include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled
> (e.g allmodconfig).
>
> The related error:
>   arch/c6x/kernel/setup.c: In function ‘setup_arch’:
>   arch/c6x/kernel/setup.c:442:2: error: ‘conswitchp’ undeclared (first use in this function)
>   arch/c6x/kernel/setup.c:442:2: note: each undeclared identifier is reported only once for each function it appears in
>   arch/c6x/kernel/setup.c:442:16: error: ‘dummy_con’ undeclared (first use in this function)

Ah, so you managed to obtain a c6x toolchain. There's none at
https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/ yet :-(

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arch: c6x: kernel: include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled.
  2013-06-25  7:06 ` Geert Uytterhoeven
@ 2013-06-25  7:34   ` Chen Gang
  0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2013-06-25  7:34 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Tony Breeds, Mark Salter, a-jacquiot@ti.com, jkc, linux-c6x-dev,
	linux-kernel@vger.kernel.org, Linux-Arch

On 06/25/2013 03:06 PM, Geert Uytterhoeven wrote:
> On Tue, Jun 25, 2013 at 3:58 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> > Need include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled
>> > (e.g allmodconfig).
>> >
>> > The related error:
>> >   arch/c6x/kernel/setup.c: In function ‘setup_arch’:
>> >   arch/c6x/kernel/setup.c:442:2: error: ‘conswitchp’ undeclared (first use in this function)
>> >   arch/c6x/kernel/setup.c:442:2: note: each undeclared identifier is reported only once for each function it appears in
>> >   arch/c6x/kernel/setup.c:442:16: error: ‘dummy_con’ undeclared (first use in this function)
> Ah, so you managed to obtain a c6x toolchain. There's none at
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/ yet :-(

Hmm..., I use:
  [root@dhcp122 linux-next]# rpm -qf /usr/bin/c6x-linux-gnu-gcc
  gcc-c6x-linux-gnu-4.7.1-0.1.20120606.fc17.x86_64

When fix the 3 compiling issues, it almost can pass compiling: during
compiled to fs subsystem, I stopped compilation manually.


Thanks.
-- 
Chen Gang

Asianux Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-06-25  7:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-25  1:58 [PATCH] arch: c6x: kernel: include "linux/console.h" when 'VT' and 'DUMMY_CONSOLE' enabled Chen Gang
2013-06-25  7:06 ` Geert Uytterhoeven
2013-06-25  7:34   ` Chen Gang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).