From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long' Date: Wed, 26 Jun 2013 10:03:58 +0800 Message-ID: <51CA4C0E.9050909@asianux.com> References: <51B2E262.3030603@asianux.com> <51B4214E.6090007@asianux.com> <20130610092106.GA4697@osiris> <51B91E32.2040502@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Return-path: Received: from intranet.asianux.com ([58.214.24.6]:33177 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742Ab3FZFcm (ORCPT ); Wed, 26 Jun 2013 01:32:42 -0400 In-Reply-To: <51B91E32.2040502@asianux.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: "uclinux-dist-devel@blackfin.uclinux.org" , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org Cc: Heiko Carstens , Bjorn Helgaas , Mike Frysinger , takata@linux-m32r.org, Martin Schwidefsky , Arnd Bergmann , realmz paranoid , linux390@de.ibm.com, "linux-kernel@vger.kernel.org" , linux-s390@vger.kernel.org, Linux-Arch , Marc Gauthier , Andrew Morton Hello Maintainers: Firstly thank the s390 maintainers again for their 'Acked-by' (in my memory, s390 is the most important business mainframe machine) Could another related maintainers give a glance for it, when you have time. Thanks. On 06/13/2013 09:19 AM, Chen Gang wrote: > On 06/10/2013 05:21 PM, Heiko Carstens wrote: >> On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote: >>>> >>>> atomic_set_mask() and atomic_clear_mask() are the pairs, so the related >>>> parameters' type need match with each other. >>>> >>>> The type of 'addr->counter' is 'int', so use 'unsigned int' instead >>>> of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask(). >>>> >>>> >>>> For arch sub-system, currently, have 3 types of definition for them: >>>> 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'. >>>> >>>> At least, better to fix 3rd (conflict using 'int' and 'long'). >>>> >>>> Signed-off-by: Chen Gang >>>> --- >>>> arch/blackfin/include/asm/atomic.h | 4 ++-- >>>> arch/m32r/include/asm/atomic.h | 8 ++++---- >>>> arch/s390/include/asm/atomic.h | 4 ++-- >>>> include/asm-generic/atomic.h | 2 +- >>>> 4 files changed, 9 insertions(+), 9 deletions(-) >> For the s390 part: >> >> Acked-by: Heiko Carstens >> > > Thank you very much !! > > -- Chen Gang Asianux Corporation