From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] arch: m32r: include: asm: add ioread*_rep() and iowrite*_rep() Date: Thu, 27 Jun 2013 16:55:09 +0800 Message-ID: <51CBFDED.9090203@asianux.com> References: <51CBA43F.9050000@asianux.com> <51CBAA1E.8000206@asianux.com> <51CBB1A9.5080203@asianux.com> <51CBC186.3080401@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from intranet.asianux.com ([58.214.24.6]:47838 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902Ab3F0I4C (ORCPT ); Thu, 27 Jun 2013 04:56:02 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Arnd Bergmann , Hirokazu Takata , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, "linux-kernel@vger.kernel.org" , Linux-Arch On 06/27/2013 03:07 PM, Geert Uytterhoeven wrote: > On Thu, Jun 27, 2013 at 6:37 AM, Chen Gang wrote: >> --- a/arch/m32r/include/asm/io.h >> +++ b/arch/m32r/include/asm/io.h >> @@ -169,6 +169,20 @@ static inline void _writel(unsigned long l, unsigned long addr) >> #define iowrite16 writew >> #define iowrite32 writel >> >> +#define ioread8_rep(p, dst, count) \ >> + insb((unsigned long) (p), (dst), (count)) > > As ioread8() is mapped to readb() (I/O memory space), not inb() (I/O > port space), > ioread8_rep() should map to readsb() (which m32r doesn't have yet > BTW), not insb(). > For m32r this does matter, as inb() and readb() use different mechanisms > internally. > Reasonable, but excuse me, I am not quite familiar with it, can any other members (or maintainer) to help implement it ? Thanks firstly. :-) > It seems include/asm-generic/io.h also has this wrong? > I think it need improvement, if readsb has been defined, it should use readsb() instead, or just use insb(). Thank you to provide a good chance to send another generic patch. ;-) -- Chen Gang