From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h" Date: Thu, 27 Jun 2013 18:14:09 +0800 Message-ID: <51CC1071.5040802@asianux.com> References: <51CBB98D.3040304@asianux.com> <20130627082920.GA14335@darko.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20130627082920.GA14335@darko.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Catalin Marinas Cc: Arnd Bergmann , Will Deacon , Geert Uytterhoeven , Hirokazu Takata , Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linux-m32r@ml.linux-m32r.org" List-Id: linux-arch.vger.kernel.org On 06/27/2013 04:29 PM, Catalin Marinas wrote: > On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote: >> > If an architecture need "generic pci.h", it also need generic "pci= -dma- >> > compat.h", so recommend to include it in asm-generic directly. >> >=20 >> > And now, for arm64 and m32r, may cause compiling error about it. >> >=20 >> > The related error (with allmodconfig): >> >=20 >> > drivers/media/usb/b2c2/flexcop-usb.c: In function =E2=80=98flexc= op_usb_transfer_exit=E2=80=99: >> > drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit decl= aration of function =E2=80=98pci_free_consistent=E2=80=99 [-Werror=3Dim= plicit-function-declaration] >> > drivers/media/usb/b2c2/flexcop-usb.c: In function =E2=80=98flexc= op_usb_transfer_init=E2=80=99: >> > drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit decl= aration of function =E2=80=98pci_alloc_consistent=E2=80=99 [-Werror=3Di= mplicit-function-declaration] >> > drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment= makes pointer from integer without a cast [enabled by default] >> > cc1: some warnings being treated as errors >> >=20 >> >=20 >> > Signed-off-by: Chen Gang > From the arm64 perspective: >=20 > Acked-by: Catalin Marinas >=20 Thanks. > (but make sure it doesn't break other archs) I will try to check all related archs with allmodconfig (which can also find more another patches, and can let me familiar the compiler step by step). ;-) Thanks. --=20 Chen Gang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from intranet.asianux.com ([58.214.24.6]:3440 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937Ab3F0KPC (ORCPT ); Thu, 27 Jun 2013 06:15:02 -0400 Message-ID: <51CC1071.5040802@asianux.com> Date: Thu, 27 Jun 2013 18:14:09 +0800 From: Chen Gang MIME-Version: 1.0 Subject: Re: [PATCH] include/asm-generic/pci.h: include generic "pci-dma-compat.h" References: <51CBB98D.3040304@asianux.com> <20130627082920.GA14335@darko.cambridge.arm.com> In-Reply-To: <20130627082920.GA14335@darko.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Catalin Marinas Cc: Arnd Bergmann , Will Deacon , Geert Uytterhoeven , Hirokazu Takata , Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-m32r-ja@ml.linux-m32r.org" , "linux-m32r@ml.linux-m32r.org" Message-ID: <20130627101409.ahJgSzr8Q4lMBcQGWhfVtLRz7Kd-62nI6TjJufOXJWw@z> On 06/27/2013 04:29 PM, Catalin Marinas wrote: > On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote: >> > If an architecture need "generic pci.h", it also need generic "pci-dma- >> > compat.h", so recommend to include it in asm-generic directly. >> > >> > And now, for arm64 and m32r, may cause compiling error about it. >> > >> > The related error (with allmodconfig): >> > >> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’: >> > drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration] >> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’: >> > drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration] >> > drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default] >> > cc1: some warnings being treated as errors >> > >> > >> > Signed-off-by: Chen Gang > From the arm64 perspective: > > Acked-by: Catalin Marinas > Thanks. > (but make sure it doesn't break other archs) I will try to check all related archs with allmodconfig (which can also find more another patches, and can let me familiar the compiler step by step). ;-) Thanks. -- Chen Gang