From: Chen Gang <gang.chen@asianux.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Richard Weinberger <richard@nod.at>,
Arnd Bergmann <arnd@arndb.de>, Jeff Dike <jdike@addtoit.com>,
David Sharp <dhsharp@google.com>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
uml-user <user-mode-linux-user@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH] include/asm-generic/io.h: add dummy fuctions to support 'COMPILE_TEST' in 'asm-generic'.
Date: Tue, 02 Jul 2013 16:00:14 +0800 [thread overview]
Message-ID: <51D2888E.8020503@asianux.com> (raw)
In-Reply-To: <CAMuHMdUvctqqStGE0QKM_BqgK2f6f_E6T=przdYszZo9A_oDzg@mail.gmail.com>
On 07/02/2013 03:19 PM, Geert Uytterhoeven wrote:
> On Tue, Jul 2, 2013 at 4:13 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> > 'asm-generic' need provide necessary configuration checking, if can't
>> > pass checking, 'asm-generic' shouldn't implement it.
>> >
>> > For 'COMPILE_TEST', according to its help contents, 'asm-generic' need
>> > let it pass configuration checking, and provide related dummy contents
>> > for it.
>> >
>> > Part of 'COMPLE_TEST' help contents in "init/Kconfig":
>> >
>> > "...Despite they cannot be loaded there (or even when they load they cannot be used due to missing HW support)..."
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Please don't clutter the code with checks for CONFIG_COMPILE_TEST.
Do you mean: 'asm-generic' should not support 'COMPILE_TEST' (the
platform should not support 'COMPILE_TEST") ?
Or you mean: 'COMPILE_TEST' should not exist in kernel ?
Can we use 'asm-default' instead of 'asm-generic', since "if HW support,
it will provide default value, or it will provide nothing" ?
Thanks.
--
Chen Gang
next prev parent reply other threads:[~2013-07-02 8:01 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 6:31 [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU' Chen Gang
2013-06-26 6:54 ` Richard Weinberger
2013-06-26 6:54 ` Richard Weinberger
2013-06-26 7:38 ` Geert Uytterhoeven
2013-06-26 7:56 ` Chen Gang
2013-06-26 7:56 ` Chen Gang
2013-06-26 8:05 ` Richard Weinberger
2013-06-26 8:34 ` Chen Gang
2013-06-26 8:34 ` Chen Gang
2013-06-26 8:39 ` Richard Weinberger
2013-06-26 8:58 ` Chen Gang
2013-06-26 9:03 ` Richard Weinberger
2013-06-26 9:33 ` Chen Gang
2013-06-26 9:38 ` Richard Weinberger
2013-06-26 9:38 ` Richard Weinberger
2013-06-26 9:48 ` Geert Uytterhoeven
2013-06-26 9:48 ` Geert Uytterhoeven
2013-06-26 10:01 ` Chen Gang
2013-06-26 10:17 ` Richard Weinberger
2013-06-26 10:22 ` Chen Gang
2013-06-26 10:22 ` Chen Gang
2013-07-01 1:40 ` Chen Gang
2013-07-01 3:43 ` Chen Gang
2013-07-02 2:13 ` [PATCH] include/asm-generic/io.h: add dummy fuctions to support 'COMPILE_TEST' in 'asm-generic' Chen Gang
2013-07-02 7:19 ` Geert Uytterhoeven
2013-07-02 7:19 ` Geert Uytterhoeven
2013-07-02 8:00 ` Chen Gang [this message]
2013-07-02 10:57 ` Geert Uytterhoeven
2013-07-03 0:51 ` Chen Gang
2013-07-03 1:26 ` Chen Gang
2013-07-03 8:14 ` Arnd Bergmann
2013-07-03 8:14 ` Arnd Bergmann
2013-07-03 8:43 ` Chen Gang
2013-07-04 0:57 ` Chen Gang
2013-07-04 1:12 ` Greg KH
2013-07-04 1:23 ` Steven Rostedt
2013-07-04 1:23 ` Steven Rostedt
2013-07-04 2:19 ` Chen Gang F T
2013-07-04 1:49 ` Chen Gang
2013-07-04 2:03 ` Steven Rostedt
2013-07-04 2:10 ` Chen Gang F T
2013-07-04 2:29 ` Steven Rostedt
2013-07-04 2:42 ` Chen Gang F T
2013-07-04 3:06 ` Steven Rostedt
2013-07-04 3:26 ` Chen Gang F T
2013-07-04 4:08 ` Greg KH
2013-07-04 4:50 ` Chen Gang
2013-07-04 6:12 ` Greg KH
2013-07-04 6:35 ` Chen Gang
2013-07-04 9:25 ` Arnd Bergmann
2013-07-04 9:25 ` Arnd Bergmann
2013-07-05 0:03 ` Chen Gang F T
2013-07-05 0:12 ` Greg KH
2013-07-05 0:35 ` Chen Gang
2013-07-05 0:52 ` Chen Gang F T
2013-07-05 0:14 ` Stephen Rothwell
2013-07-05 0:48 ` Chen Gang F T
2013-07-05 8:01 ` Chen Gang F T
2013-07-05 11:13 ` Arnd Bergmann
2013-07-05 11:13 ` Arnd Bergmann
2013-07-08 2:10 ` Chen Gang F T
2013-07-04 8:09 ` Geert Uytterhoeven
2013-07-05 0:10 ` Chen Gang
2013-06-26 9:54 ` [PATCH] include/asm-generic/io.h: add 'UML' case just like 'no-MMU' Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D2888E.8020503@asianux.com \
--to=gang.chen@asianux.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dhsharp@google.com \
--cc=geert@linux-m68k.org \
--cc=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=trivial@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).