Re: [PATCH] metag: move EXPORT_SYMBOLs in libs to metag_ksyms.c

[James Hogan <james.hogan@imgtec.com>]

(cc'ing linux-arch and linux-kbuild)

On 03/07/13 01:45, Rusty Russell wrote:
> James Hogan <james.hogan@imgtec.com> writes:
>> Move all EXPORT_SYMBOLs in libs-y directories (arch/metag/{lib,tbx})
>> into metag_ksyms.c so that they don't get omitted by the static linker
>> if they're not used by any other statically linked code, which can
>> result in undefined symbols when building modules.
>>
>> For example a randconfig caused the following error:
>> ERROR: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined!
>>
>> Signed-off-by: James Hogan <james.hogan@imgtec.com>
>> Cc: Rusty Russell <rusty@rustcorp.com.au>
>> ---
>> Unless there are any objections I'll apply this patch for v3.11. I'm
>> assuming *_ksyms.c is the way that this problem is normally worked
>> around.
> 
> Actually, normally those files are obj-y not lib-y.  See the top-level
> lib/.
> 
> Subtle, I know.

Hmm, subtle indeed, I hadn't noticed that.

grepping for EXPORT_SYMBOL(csum_partial) gives:

./arch/avr32/kernel/avr32_ksyms.c
./arch/sparc/lib/ksyms.c
./arch/sh/kernel/sh_ksyms_32.c
./arch/powerpc/kernel/ppc_ksyms.c
./arch/unicore32/kernel/ksyms.c
./arch/x86/um/ksyms.c
./arch/x86/kernel/x8664_ksyms_64.c
./arch/x86/kernel/i386_ksyms_32.c
./arch/cris/kernel/crisksyms.c
./arch/mips/kernel/mips_ksyms.c
./arch/xtensa/kernel/xtensa_ksyms.c
./arch/arm/kernel/armksyms.c

./arch/ia64/lib/checksum.c
./arch/alpha/lib/checksum.c
./arch/c6x/lib/checksum.c
./arch/mn10300/lib/checksum.c
./arch/cris/arch-v10/lib/old_checksum.c
./arch/h8300/lib/checksum.c
./arch/parisc/lib/checksum.c
./arch/m32r/lib/csum_partial_copy.c
./arch/m68k/lib/checksum.c
./arch/metag/lib/checksum.c
./arch/frv/lib/checksum.c

./lib/checksum.c

All of the above arches have *c*sum.o in lib-y. Should they all be
switched to obj-y or the remaining EXPORT_SYMBOLs moved to *ksyms.c if
this problem is noticed?

Thanks
James