From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Metcalf Subject: Re: [PATCH v2] arch: tile: include: asm: add cmpxchg64() definition Date: Wed, 17 Jul 2013 12:46:19 -0400 Message-ID: <51E6CA5B.6030501@tilera.com> References: <51CA6D21.3090901@asianux.com> <51CC492C.1040105@tilera.com> <51CCD891.8000806@asianux.com> <51CCEC27.8050508@asianux.com> <20130628150941.GA22767@linux-mips.org> <51D0E4B3.6080402@asianux.com> <51D0E7BF.9030206@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <51D0E7BF.9030206@asianux.com> Sender: linux-kernel-owner@vger.kernel.org To: Chen Gang Cc: Ralf Baechle , =?UTF-8?B?SsO2cm4gRW5nZWw=?= , "linux-kernel@vger.kernel.org" , Linux-Arch , Paul Gortmaker List-Id: linux-arch.vger.kernel.org On 6/30/2013 10:21 PM, Chen Gang wrote: > Need add cmpxchg64(), or will cause compiling issue. > > Need define it as cmpxchg() only for 64-bit operation, since cmpxchg(= ) > can support 8 bytes. > > The related error (with allmodconfig): > > drivers/block/blockconsole.c: In function =E2=80=98bcon_advance_con= sole_bytes=E2=80=99: > drivers/block/blockconsole.c:164:2: error: implicit declaration of = function =E2=80=98cmpxchg64=E2=80=99 [-Werror=3Dimplicit-function-decla= ration] > > Signed-off-by: Chen Gang Thanks, taken into the tile tree. --=20 Chris Metcalf, Tilera Corp. http://www.tilera.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usmamail.tilera.com ([12.216.194.151]:7997 "EHLO USMAMAIL.TILERA.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933167Ab3GQQqV (ORCPT ); Wed, 17 Jul 2013 12:46:21 -0400 Message-ID: <51E6CA5B.6030501@tilera.com> Date: Wed, 17 Jul 2013 12:46:19 -0400 From: Chris Metcalf MIME-Version: 1.0 Subject: Re: [PATCH v2] arch: tile: include: asm: add cmpxchg64() definition References: <51CA6D21.3090901@asianux.com> <51CC492C.1040105@tilera.com> <51CCD891.8000806@asianux.com> <51CCEC27.8050508@asianux.com> <20130628150941.GA22767@linux-mips.org> <51D0E4B3.6080402@asianux.com> <51D0E7BF.9030206@asianux.com> In-Reply-To: <51D0E7BF.9030206@asianux.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chen Gang Cc: Ralf Baechle , =?UTF-8?B?SsO2cm4gRW5nZWw=?= , "linux-kernel@vger.kernel.org" , Linux-Arch , Paul Gortmaker Message-ID: <20130717164619.ud3SsiVNR_ScMqP6cbApd9W-fCV6-YKiSnCi5TTlycM@z> On 6/30/2013 10:21 PM, Chen Gang wrote: > Need add cmpxchg64(), or will cause compiling issue. > > Need define it as cmpxchg() only for 64-bit operation, since cmpxchg() > can support 8 bytes. > > The related error (with allmodconfig): > > drivers/block/blockconsole.c: In function ‘bcon_advance_console_bytes’: > drivers/block/blockconsole.c:164:2: error: implicit declaration of function ‘cmpxchg64’ [-Werror=implicit-function-declaration] > > Signed-off-by: Chen Gang Thanks, taken into the tile tree. -- Chris Metcalf, Tilera Corp. http://www.tilera.com