Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

[Greg Ungerer <gerg@uclinux.org>]

Hi Chen Gang,

On 01/07/13 12:43, Chen Gang wrote:
> Hello Maintainers:
> 
> Please help check the patch whether OK or not, when you have time.
> 
> Thanks.
> 
> On 06/22/2013 02:49 PM, Chen Gang wrote:
>>
>> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling.
>>
>> So move it from "include/asm/page_mm.h to "include/asm/page.h"
>>
>> The related make:
>>
>>   make ARCH=m68k randconfig
>>   make ARCH=m68k menuconfig
>>     choose cross compiler
>>     disable MMU support
>>   make ARCH=m68k V=1 EXTRA_CFLAGS=-W
>>
>> The related error:
>>
>>   security/selinux/hooks.c: In function ‘selinux_init’:
>>   security/selinux/hooks.c:5821:21: error: ‘VM_DATA_DEFAULT_FLAGS’ undeclared (first use in this function)
>>
>> (the attachment is the related .config file)
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>

I am fine with this:

Acked-by: Greg Ungerer <gerg@uclinux.org>

Do you want me to add this to the m68knommu git tree, and push to
Linus?

Regards
Greg


>> ---
>>  arch/m68k/include/asm/page.h    |    3 +++
>>  arch/m68k/include/asm/page_mm.h |    3 ---
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
>> index 7c360da..38b024a 100644
>> --- a/arch/m68k/include/asm/page.h
>> +++ b/arch/m68k/include/asm/page.h
>> @@ -48,6 +48,9 @@ extern unsigned long _ramend;
>>  #include <asm/page_no.h>
>>  #endif
>>  
>> +#define VM_DATA_DEFAULT_FLAGS	(VM_READ | VM_WRITE | VM_EXEC | \
>> +				 VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>> +
>>  #include <asm-generic/getorder.h>
>>  
>>  #endif /* _M68K_PAGE_H */
>> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
>> index 89f2014..5029f73 100644
>> --- a/arch/m68k/include/asm/page_mm.h
>> +++ b/arch/m68k/include/asm/page_mm.h
>> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
>>  
>>  #endif /* __ASSEMBLY__ */
>>  
>> -#define VM_DATA_DEFAULT_FLAGS	(VM_READ | VM_WRITE | VM_EXEC | \
>> -				 VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>> -
>>  #endif /* _M68K_PAGE_MM_H */
>>
> 
>