From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Ungerer Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not. Date: Mon, 05 Aug 2013 11:37:43 +1000 Message-ID: <51FF01E7.5020105@uclinux.org> References: <51C548E2.1060104@asianux.com> <51D0ECC2.3020101@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <51D0ECC2.3020101@asianux.com> Sender: linux-kernel-owner@vger.kernel.org To: Chen Gang Cc: Geert Uytterhoeven , Paul McKenney , "dhowells@redhat.com" , Thomas Gleixner , davej@redhat.com, Arnd Bergmann , linux-m68k , "linux-kernel@vger.kernel.org" , Linux-Arch List-Id: linux-arch.vger.kernel.org Hi Chen Gang, On 01/07/13 12:43, Chen Gang wrote: > Hello Maintainers: >=20 > Please help check the patch whether OK or not, when you have time. >=20 > Thanks. >=20 > On 06/22/2013 02:49 PM, Chen Gang wrote: >> >> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling. >> >> So move it from "include/asm/page_mm.h to "include/asm/page.h" >> >> The related make: >> >> make ARCH=3Dm68k randconfig >> make ARCH=3Dm68k menuconfig >> choose cross compiler >> disable MMU support >> make ARCH=3Dm68k V=3D1 EXTRA_CFLAGS=3D-W >> >> The related error: >> >> security/selinux/hooks.c: In function =E2=80=98selinux_init=E2=80=99= : >> security/selinux/hooks.c:5821:21: error: =E2=80=98VM_DATA_DEFAULT_= =46LAGS=E2=80=99 undeclared (first use in this function) >> >> (the attachment is the related .config file) >> >> >> Signed-off-by: Chen Gang I am fine with this: Acked-by: Greg Ungerer Do you want me to add this to the m68knommu git tree, and push to Linus? Regards Greg >> --- >> arch/m68k/include/asm/page.h | 3 +++ >> arch/m68k/include/asm/page_mm.h | 3 --- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/pa= ge.h >> index 7c360da..38b024a 100644 >> --- a/arch/m68k/include/asm/page.h >> +++ b/arch/m68k/include/asm/page.h >> @@ -48,6 +48,9 @@ extern unsigned long _ramend; >> #include >> #endif >> =20 >> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \ >> + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC) >> + >> #include >> =20 >> #endif /* _M68K_PAGE_H */ >> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm= /page_mm.h >> index 89f2014..5029f73 100644 >> --- a/arch/m68k/include/asm/page_mm.h >> +++ b/arch/m68k/include/asm/page_mm.h >> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_= node_shift(void) >> =20 >> #endif /* __ASSEMBLY__ */ >> =20 >> -#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \ >> - VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC) >> - >> #endif /* _M68K_PAGE_MM_H */ >> >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-mail02.westnet.com.au ([203.10.1.243]:10854 "EHLO outbound-mail02.westnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754039Ab3HEBuX (ORCPT ); Sun, 4 Aug 2013 21:50:23 -0400 Message-ID: <51FF01E7.5020105@uclinux.org> Date: Mon, 05 Aug 2013 11:37:43 +1000 From: Greg Ungerer MIME-Version: 1.0 Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not. References: <51C548E2.1060104@asianux.com> <51D0ECC2.3020101@asianux.com> In-Reply-To: <51D0ECC2.3020101@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chen Gang Cc: Geert Uytterhoeven , Paul McKenney , "dhowells@redhat.com" , Thomas Gleixner , davej@redhat.com, Arnd Bergmann , linux-m68k , "linux-kernel@vger.kernel.org" , Linux-Arch Message-ID: <20130805013743.I8-a_BDUQIvskl3ylGi2F6BXXYpu5dX_hA0kvjTVUiI@z> Hi Chen Gang, On 01/07/13 12:43, Chen Gang wrote: > Hello Maintainers: > > Please help check the patch whether OK or not, when you have time. > > Thanks. > > On 06/22/2013 02:49 PM, Chen Gang wrote: >> >> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling. >> >> So move it from "include/asm/page_mm.h to "include/asm/page.h" >> >> The related make: >> >> make ARCH=m68k randconfig >> make ARCH=m68k menuconfig >> choose cross compiler >> disable MMU support >> make ARCH=m68k V=1 EXTRA_CFLAGS=-W >> >> The related error: >> >> security/selinux/hooks.c: In function ‘selinux_init’: >> security/selinux/hooks.c:5821:21: error: ‘VM_DATA_DEFAULT_FLAGS’ undeclared (first use in this function) >> >> (the attachment is the related .config file) >> >> >> Signed-off-by: Chen Gang I am fine with this: Acked-by: Greg Ungerer Do you want me to add this to the m68knommu git tree, and push to Linus? Regards Greg >> --- >> arch/m68k/include/asm/page.h | 3 +++ >> arch/m68k/include/asm/page_mm.h | 3 --- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h >> index 7c360da..38b024a 100644 >> --- a/arch/m68k/include/asm/page.h >> +++ b/arch/m68k/include/asm/page.h >> @@ -48,6 +48,9 @@ extern unsigned long _ramend; >> #include >> #endif >> >> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \ >> + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC) >> + >> #include >> >> #endif /* _M68K_PAGE_H */ >> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h >> index 89f2014..5029f73 100644 >> --- a/arch/m68k/include/asm/page_mm.h >> +++ b/arch/m68k/include/asm/page_mm.h >> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void) >> >> #endif /* __ASSEMBLY__ */ >> >> -#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \ >> - VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC) >> - >> #endif /* _M68K_PAGE_MM_H */ >> > >