From: James Hogan <james.hogan@imgtec.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Arnd Bergmann <arnd@arndb.de>, Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] asm-generic: Add missing include guards
Date: Tue, 27 Aug 2013 14:08:44 +0100 [thread overview]
Message-ID: <521CA4DC.6010506@imgtec.com> (raw)
In-Reply-To: <1375996022-8298-4-git-send-email-linux@rasmusvillemoes.dk>
On 08/08/13 22:07, Rasmus Villemoes wrote:
> Add include guards to include/asm-generic/{ide_iops,unistd,xor}.h.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> include/asm-generic/ide_iops.h | 4 ++++
> include/asm-generic/unistd.h | 5 +++++
> include/asm-generic/xor.h | 4 ++++
> 3 files changed, 13 insertions(+)
>
> diff --git a/include/asm-generic/unistd.h b/include/asm-generic/unistd.h
> index cccc86e..0cff2e9 100644
> --- a/include/asm-generic/unistd.h
> +++ b/include/asm-generic/unistd.h
> @@ -1,3 +1,6 @@
> +#ifndef _ASM_GENERIC_UNISTD_H
> +#define _ASM_GENERIC_UNISTD_H
> +
> #include <uapi/asm-generic/unistd.h>
> #include <linux/export.h>
>
> @@ -10,3 +13,5 @@
> #define __ARCH_WANT_STAT64
> #define __ARCH_WANT_SYS_LLSEEK
> #endif
> +
> +#endif /* _ASM_GENERIC_UNISTD_H */
I think the lack of include guards in unistd.h is intentional. See for
example the very end of arch/metag/kernel/sys_metag.c.
Cheers
James
next prev parent reply other threads:[~2013-08-27 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 21:06 [PATCH 0/4] asm-generic: fix minor include guard issues Rasmus Villemoes
2013-08-08 21:06 ` [PATCH 1/4] asm-generic: Make sure include guards contain the substring ASM_GENERIC Rasmus Villemoes
2013-08-08 21:06 ` Rasmus Villemoes
2013-08-08 21:07 ` [PATCH 2/4] asm-generic: Use different include guards Rasmus Villemoes
2013-08-08 21:07 ` Rasmus Villemoes
2013-08-08 21:07 ` [PATCH 3/4] asm-generic: Add missing " Rasmus Villemoes
2013-08-08 21:07 ` Rasmus Villemoes
2013-08-27 13:08 ` James Hogan [this message]
2013-08-08 21:07 ` [PATCH 4/4] asm-generic: Fix typo in comment after #endif Rasmus Villemoes
2013-08-08 21:07 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521CA4DC.6010506@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).