From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH 2/8] um: Do not use SUBARCH Date: Thu, 26 Sep 2013 16:24:44 +0200 Message-ID: <524443AC.3040409@nod.at> References: <1377073172-3662-1-git-send-email-richard@nod.at> <1377073172-3662-3-git-send-email-richard@nod.at> <52441025.9030308@nod.at> <52441407.9010603@nod.at> <52442108.1020304@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Ramkumar Ramachandra , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , LKML , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel List-Id: linux-arch.vger.kernel.org Am 26.09.2013 15:26, schrieb Geert Uytterhoeven: > On Thu, Sep 26, 2013 at 3:13 PM, Ramkumar Ramachandra > wrote: >> Ramkumar Ramachandra wrote: >>> Richard Weinberger wrote: >>>> I told you already that "make defconfig ARCH=um SUBARCH=x86" will spuriously >>>> create a x86_64 config on x86_64. >>>> This breaks existing setups. >>> >>> I'll fix this and resubmit soon. >> >> Wait a minute. You're now arguing about whether the generic "x86" >> means i386 or x86_64. Its meaning is already defined in >> arch/x86/Kconfig and arch/x86/um/Kconfig: see the config 64BIT. Unless >> i386 is explicitly specified, the default is to build a 64-bit kernel. >> That is already defined for a normal Linux kernel, and user-mode Linux >> should not break that convention. So, in the example you pulled out of >> your hat: >> >> $ make defconfig ARCH=um SUBARCH=x86 >> >> the user should expect a 64-bit build, and not an i386 build as you >> say. Both my patches are correct, and the "regression" that you >> pointed out is a red herring. > > Sorry for chiming in, but... what about cross compiling? > SUBARCH=x86 should give you a 32-bit ia32 kernel, right? Correct. Users expect from SUBARCH=x86 a i386 32bit UML kernel. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from b.ns.miles-group.at ([95.130.255.144]:1662 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750803Ab3IZOYt (ORCPT ); Thu, 26 Sep 2013 10:24:49 -0400 Message-ID: <524443AC.3040409@nod.at> Date: Thu, 26 Sep 2013 16:24:44 +0200 From: Richard Weinberger MIME-Version: 1.0 Subject: Re: [PATCH 2/8] um: Do not use SUBARCH References: <1377073172-3662-1-git-send-email-richard@nod.at> <1377073172-3662-3-git-send-email-richard@nod.at> <52441025.9030308@nod.at> <52441407.9010603@nod.at> <52442108.1020304@nod.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Ramkumar Ramachandra , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , LKML , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel Message-ID: <20130926142444.PNz1aY4SmzvvLtrinb1008hd7yrT07G4rJBDf-EgcH0@z> Am 26.09.2013 15:26, schrieb Geert Uytterhoeven: > On Thu, Sep 26, 2013 at 3:13 PM, Ramkumar Ramachandra > wrote: >> Ramkumar Ramachandra wrote: >>> Richard Weinberger wrote: >>>> I told you already that "make defconfig ARCH=um SUBARCH=x86" will spuriously >>>> create a x86_64 config on x86_64. >>>> This breaks existing setups. >>> >>> I'll fix this and resubmit soon. >> >> Wait a minute. You're now arguing about whether the generic "x86" >> means i386 or x86_64. Its meaning is already defined in >> arch/x86/Kconfig and arch/x86/um/Kconfig: see the config 64BIT. Unless >> i386 is explicitly specified, the default is to build a 64-bit kernel. >> That is already defined for a normal Linux kernel, and user-mode Linux >> should not break that convention. So, in the example you pulled out of >> your hat: >> >> $ make defconfig ARCH=um SUBARCH=x86 >> >> the user should expect a 64-bit build, and not an i386 build as you >> say. Both my patches are correct, and the "regression" that you >> pointed out is a red herring. > > Sorry for chiming in, but... what about cross compiling? > SUBARCH=x86 should give you a 32-bit ia32 kernel, right? Correct. Users expect from SUBARCH=x86 a i386 32bit UML kernel. Thanks, //richard