From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH 2/8] um: Do not use SUBARCH Date: Thu, 26 Sep 2013 19:10:33 +0200 Message-ID: <52446A89.1080409@nod.at> References: <1377073172-3662-1-git-send-email-richard@nod.at> <1377073172-3662-3-git-send-email-richard@nod.at> <52441025.9030308@nod.at> <52441407.9010603@nod.at> <52442108.1020304@nod.at> <524443AC.3040409@nod.at> <52444CED.40401@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org To: Ramkumar Ramachandra Cc: Geert Uytterhoeven , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , LKML , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel List-Id: linux-arch.vger.kernel.org Am 26.09.2013 18:06, schrieb Ramkumar Ramachandra: > Richard Weinberger wrote: >> And, of course, this makes your patch valid. >> Can you also please ensure that your new defconfigs are minimal? > > Yeah, it's close to a minimal configuration for the 3.10 kernel > (latest at the time of patch submission). I was aiming to minimize the > diff between the current defconfig and the two new defconfigs in > configs/. The slim diffstat does the talking: > > arch/um/Kconfig.common | 5 - > arch/um/Makefile | 11 ++ > arch/um/{defconfig => configs/i386_defconfig} | 209 +++++++++++++------- > arch/um/{defconfig => configs/x86_64_defconfig} | 250 +++++++++++++++--------- > arch/x86/um/Kconfig | 5 + > 5 files changed, 306 insertions(+), 174 deletions(-) > copy arch/um/{defconfig => configs/i386_defconfig} (86%) > rename arch/um/{defconfig => configs/x86_64_defconfig} (83%) > > If we find some deficiencies, we can always update it. For now, please > commit these two patches. Please resend them with savedefconfig applied. There is no need to have three commits for that. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from b.ns.miles-group.at ([95.130.255.144]:1660 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752562Ab3IZRKk (ORCPT ); Thu, 26 Sep 2013 13:10:40 -0400 Message-ID: <52446A89.1080409@nod.at> Date: Thu, 26 Sep 2013 19:10:33 +0200 From: Richard Weinberger MIME-Version: 1.0 Subject: Re: [PATCH 2/8] um: Do not use SUBARCH References: <1377073172-3662-1-git-send-email-richard@nod.at> <1377073172-3662-3-git-send-email-richard@nod.at> <52441025.9030308@nod.at> <52441407.9010603@nod.at> <52442108.1020304@nod.at> <524443AC.3040409@nod.at> <52444CED.40401@nod.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ramkumar Ramachandra Cc: Geert Uytterhoeven , Linux-Arch , Michal Marek , Ralf Baechle , Paul Mundt , Jeff Dike , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , linux-kbuild , LKML , linux-m68k , Linux MIPS Mailing List , Linux-sh list , uml-devel Message-ID: <20130926171033.v9nBs9Xyaj9-oJBW-sRTnRHVSo5vjgA94j2X2i38Aw8@z> Am 26.09.2013 18:06, schrieb Ramkumar Ramachandra: > Richard Weinberger wrote: >> And, of course, this makes your patch valid. >> Can you also please ensure that your new defconfigs are minimal? > > Yeah, it's close to a minimal configuration for the 3.10 kernel > (latest at the time of patch submission). I was aiming to minimize the > diff between the current defconfig and the two new defconfigs in > configs/. The slim diffstat does the talking: > > arch/um/Kconfig.common | 5 - > arch/um/Makefile | 11 ++ > arch/um/{defconfig => configs/i386_defconfig} | 209 +++++++++++++------- > arch/um/{defconfig => configs/x86_64_defconfig} | 250 +++++++++++++++--------- > arch/x86/um/Kconfig | 5 + > 5 files changed, 306 insertions(+), 174 deletions(-) > copy arch/um/{defconfig => configs/i386_defconfig} (86%) > rename arch/um/{defconfig => configs/x86_64_defconfig} (83%) > > If we find some deficiencies, we can always update it. For now, please > commit these two patches. Please resend them with savedefconfig applied. There is no need to have three commits for that. Thanks, //richard