From: Vineet Gupta <vineetg76@gmail.com>
To: Chen Gang <gang.chen@asianux.com>, James Hogan <james.hogan@imgtec.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro
Date: Mon, 28 Oct 2013 19:15:54 +0530 [thread overview]
Message-ID: <526E6A92.6090301@synopsys.com> (raw)
In-Reply-To: <526E3CE2.2070405@asianux.com>
On 10/28/2013 04:00 PM, Chen Gang wrote:
> For some toolchains, they use another character as newline in a macro
> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a
> macro) instead of ';' for it.
>
> Since "linux/export.h" are mainly used for exporting work, then our fix
> more likely belongs to "linux/linkage.h", and we need add the related
> checking in "linkage.h".
>
> Also need notice 80 columns wrap, and '\t' for each line.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arc/include/asm/linkage.h | 2 +
> include/asm-generic/vmlinux.lds.h | 350 +++++++++++++++++++------------------
> include/linux/linkage.h | 19 +
Like Max said, please drop the linker script bits - they are OK - otherwise ARC
kernel won't have been building at all.
And you also need to fix kernel/modsign_certificate.S as part of same patchset as
that is where the problem started in first place.
-Vineet
next prev parent reply other threads:[~2013-10-28 13:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 10:30 [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro Chen Gang
2013-10-28 11:18 ` Max Filippov
2013-10-29 7:57 ` Chen Gang
2013-10-29 7:57 ` Chen Gang
2013-10-29 8:34 ` Max Filippov
2013-10-29 8:34 ` Max Filippov
2013-10-29 8:47 ` Chen Gang
2013-10-28 13:45 ` Vineet Gupta [this message]
2013-10-29 1:04 ` Chen Gang
2013-10-29 1:39 ` Chen Gang
2013-10-29 1:51 ` [PATCH v2] " Chen Gang
2013-10-29 5:55 ` Vineet Gupta
2013-10-29 6:07 ` Chen Gang
2013-11-01 5:45 ` Vineet Gupta
2013-11-21 9:58 ` Vineet Gupta
2013-11-21 10:52 ` Chen Gang
2014-01-03 12:38 ` Michal Marek
2014-01-03 12:38 ` Michal Marek
2014-01-06 5:36 ` Vineet Gupta
2014-01-06 9:26 ` Michal Marek
2014-01-09 6:41 ` Vineet Gupta
2014-01-10 15:48 ` Chen Gang
2014-01-10 15:48 ` Chen Gang
2014-01-12 1:59 ` [PATCH v3] " Chen Gang
2014-01-18 9:44 ` Chen Gang
2014-01-21 4:55 ` Vineet Gupta
2014-01-25 11:07 ` Chen Gang
2014-01-27 21:57 ` Michal Marek
2014-01-30 5:41 ` Chen Gang
2014-01-30 5:41 ` Chen Gang
2013-10-29 10:39 ` [PATCH] " David Howells
2013-10-29 11:53 ` Chen Gang
2013-10-29 13:59 ` David Howells
2013-10-30 0:57 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526E6A92.6090301@synopsys.com \
--to=vineetg76@gmail.com \
--cc=arnd@arndb.de \
--cc=gang.chen@asianux.com \
--cc=james.hogan@imgtec.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).