From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -tip v3 18/23] x86/dumpstack: Use NOKPROBE_SYMBOL macro in dumpstack.c Date: Fri, 22 Nov 2013 11:08:08 +0900 Message-ID: <528EBC88.2030609@hitachi.com> References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> <20131120042233.15296.31189.stgit@kbuild-fedora.novalocal> <20131121113006.GA27659@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail7.hitachi.co.jp ([133.145.228.42]:37896 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753021Ab3KVCIO (ORCPT ); Thu, 21 Nov 2013 21:08:14 -0500 In-Reply-To: <20131121113006.GA27659@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ingo Molnar Cc: linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Sandeepa Prabhu , Vineet Gupta , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, Andrew Morton , Ingo Molnar , systemtap@sourceware.org, "H. Peter Anvin" , Tejun Heo , Thomas Gleixner , Jiri Slaby , "David S. Miller" (2013/11/21 20:30), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> Use NOKPROBE_SYMBOL macro for protecting functions >> from kprobes instead of __kprobes annotation in >> dumpstack.c. >> >> Signed-off-by: Masami Hiramatsu >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: "H. Peter Anvin" >> Cc: Andrew Morton >> Cc: Jiri Slaby >> Cc: Tejun Heo >> Cc: Vineet Gupta >> --- >> arch/x86/kernel/dumpstack.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Btw., all these mechanic changes of the __kprobes annotation can be > merged into a single patch. That will cut down on the size of the > series substantially. Right, I just thought it would be easy to review for each subsystem maintainer, because some of them including forcibly (or explicitly) inlined changes (__always_inline). Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com