From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet Gupta Subject: Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro Date: Thu, 9 Jan 2014 12:11:26 +0530 Message-ID: <52CE4496.5030401@synopsys.com> References: <526E3CE2.2070405@asianux.com> <526E6A92.6090301@synopsys.com> <526F09B8.9030202@asianux.com> <526F11C0.1030809@asianux.com> <526F149A.3000306@asianux.com> <52733FEC.4010807@synopsys.com> <528DD92E.9070408@synopsys.com> <52C6AF2B.8050104@suse.cz> <52CA76D3.2010102@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-relay.synopsys.com ([198.182.44.81]:46243 "EHLO smtp-relay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbaAIGlm (ORCPT ); Thu, 9 Jan 2014 01:41:42 -0500 In-Reply-To: <52CA76D3.2010102@suse.cz> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chen Gang Cc: Michal Marek , "linux-kernel@vger.kernel.org" , Linux-Arch Forwarding to Chen's email address: On Monday 06 January 2014 02:56 PM, Michal Marek wrote: > On 2014-01-06 06:36, Vineet Gupta wrote: >> Hi Michal, >> >> On Friday 03 January 2014 06:08 PM, Michal Marek wrote: >>> On 2013-11-21 10:58, Vineet Gupta wrote: >>>> On 11/01/2013 11:15 AM, Vineet Gupta wrote: >>>>> +CC Sam, Tim, Joe, Michal, David >>>>> >>>>> Guys can you please take a look at this patch and suggest the best way to merge. >>>>> >>>>> The root cause is some gas ports (including ARC) use ';' for comment (vs. newline) >>>>> More background at https://lkml.org/lkml/2013/10/24/365 >>>> Ping ! Any objections to this. Given that this is exception case, it is simpler >>>> than defining a Kconfig control. >>>> >>>> -Vineet >>>>> >>>>> On 10/29/2013 07:21 AM, Chen Gang wrote: >>>>>> For some assemblers, they use another character as newline in a macro >>>>>> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >>>>>> macro) instead of ';' for it. >>>>>> >>>>>> Also need notice about code styles ('\t' for each line). >>>>>> >>>>>> >>>>>> Signed-off-by: Chen Gang > >> >> Did you hit reply by mistake - as I can't seem to find any comments... > > Oops :). I wanted to ask if this is the final patch that should be > merged, or if there are more known instances of .S code that needs > s/;/ASM_NL/. I did not find any suspects outside arch/ by grepping. If > this is the final patch, Chen, could you please resubmit it? I do not > have the original copy. > > Michal > -Vineet