From: Waiman Long <waiman.long@hp.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
George Spelvin <linux@horizon.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
"Chandramouleeswaran, Aswin" <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH v10 1/4] qrwlock: A queue read/write lock implementation
Date: Thu, 23 Jan 2014 15:45:50 -0500 [thread overview]
Message-ID: <52E17F7E.1030803@hp.com> (raw)
In-Reply-To: <CA+55aFyb-qFpUWGZjXJx_V_tr43XYGGL9srfrZf6qhxV_qPfVg@mail.gmail.com>
On 01/23/2014 12:52 PM, Linus Torvalds wrote:
> On Thu, Jan 23, 2014 at 9:47 AM, Waiman Long<waiman.long@hp.com> wrote:
>> Thank for the info. I am less familiar with that kind of issues on other
>> architecture. I will add a smp_mb__after_atomic_dec()& send out a new
>> patch.
> SInce it's the unlock path,. you need to use the "mb__*before*"
> versions, since presumably you want to protect what is inside the lock
> from leaking out, not some random thing after the lock from leaking
> in..
>
> Linus
My bad. I am a bit sloppy not using the right function in my email. I
will certainly put the right mb functions depending on whether it is a
lock or unlock function.
-Longman
next prev parent reply other threads:[~2014-01-23 20:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 21:33 [PATCH v10 0/4] Introducing a queue read/write lock implementation Waiman Long
2014-01-22 21:33 ` [PATCH v10 1/4] qrwlock: A " Waiman Long
2014-01-22 21:33 ` Waiman Long
2014-01-23 10:07 ` Peter Zijlstra
2014-01-23 17:12 ` Waiman Long
2014-01-23 17:15 ` Linus Torvalds
2014-01-23 17:38 ` Peter Zijlstra
2014-01-23 17:47 ` Waiman Long
2014-01-23 17:47 ` Waiman Long
2014-01-23 17:52 ` Linus Torvalds
2014-01-23 17:52 ` Linus Torvalds
2014-01-23 20:45 ` Waiman Long [this message]
2014-01-23 20:45 ` Waiman Long
2014-01-22 21:33 ` [PATCH v10 2/4] qrwlock, x86: Enable x86 to use queue read/write lock Waiman Long
2014-01-22 21:33 ` Waiman Long
2014-01-22 21:33 ` [PATCH v10 3/4] qrwlock, x86: Add char and short as atomic data type in x86 Waiman Long
2014-01-22 21:33 ` [PATCH v10 4/4] qrwlock: Use the mcs_spinlock helper functions for MCS queuing Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E17F7E.1030803@hp.com \
--to=waiman.long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).