From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghavendra K T Subject: Re: [PATCH v3 0/2] qspinlock: Introducing a 4-byte queue spinlock Date: Mon, 03 Feb 2014 14:21:23 +0530 Message-ID: <52EF588B.4050904@linux.vnet.ibm.com> References: <1390933151-1797-1-git-send-email-Waiman.Long@hp.com> <52EA139C.8040106@linux.vnet.ibm.com> <52EA71F8.7070308@hp.com> <52EA9ECA.5040400@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <52EA9ECA.5040400@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Waiman Long Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Arnd Bergmann , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Steven Rostedt , Andrew Morton , Michel Lespinasse , Andi Kleen , Rik van Riel , "Paul E. McKenney" , Linus Torvalds , George Spelvin , Tim Chen , Daniel J Blueman , Alexander Fyodorov , Aswin Chandramouleeswaran , Scott J Norton , Thavatchai Makphaibulchoke List-Id: linux-arch.vger.kernel.org On 01/31/2014 12:19 AM, Raghavendra K T wrote: > On 01/30/2014 09:08 PM, Waiman Long wrote: >> On 01/30/2014 03:55 AM, Raghavendra K T wrote: >>> On 01/28/2014 11:49 PM, Waiman Long wrote: > [...] > from kernel/bounds.c:9: >>> include/linux/log2.h: In function =E2=80=98__ilog2_u32=E2=80=99: >>> include/linux/log2.h:34:2: error: implicit declaration of function >>> =E2=80=98fls=E2=80=99 [-Werror=3Dimplicit-function-declaration] >>> include/linux/log2.h: In function =E2=80=98__ilog2_u64=E2=80=99: >>> include/linux/log2.h:42:2: error: implicit declaration of function >>> =E2=80=98fls64=E2=80=99 [-Werror=3Dimplicit-function-declaration] >>> include/linux/log2.h: In function =E2=80=98__roundup_pow_of_two=E2=80= =99: >>> . >>> . >>> [trimmed] >>> >> >> The code will need to be compiled in either the latest linux tree as= the >> patches have dependency on some new memory barrier that are in 3.14. >> Alternatively, you can compile with the latest tip tree. >> >> If you have already done that, please send me your config file so th= at I >> can reproduce the compilation error in my build environment. >> > > I did compile on latest linux tree which had barrier.txt. May be I 'l= l > recheck if I am missing something obvious. > > Here is .config attached An Update: The reason for failure was that I was compiling for guest. and CONFIG_PARAVIRT was enabled. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp07.au.ibm.com ([202.81.31.140]:40528 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbaBCIpR (ORCPT ); Mon, 3 Feb 2014 03:45:17 -0500 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Feb 2014 18:45:16 +1000 Message-ID: <52EF588B.4050904@linux.vnet.ibm.com> Date: Mon, 03 Feb 2014 14:21:23 +0530 From: Raghavendra K T MIME-Version: 1.0 Subject: Re: [PATCH v3 0/2] qspinlock: Introducing a 4-byte queue spinlock References: <1390933151-1797-1-git-send-email-Waiman.Long@hp.com> <52EA139C.8040106@linux.vnet.ibm.com> <52EA71F8.7070308@hp.com> <52EA9ECA.5040400@linux.vnet.ibm.com> In-Reply-To: <52EA9ECA.5040400@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Waiman Long Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Arnd Bergmann , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Steven Rostedt , Andrew Morton , Michel Lespinasse , Andi Kleen , Rik van Riel , "Paul E. McKenney" , Linus Torvalds , George Spelvin , Tim Chen , Daniel J Blueman , Alexander Fyodorov , Aswin Chandramouleeswaran , Scott J Norton , Thavatchai Makphaibulchoke Message-ID: <20140203085123.Zm2q5Nhhw9lGucy8vbPHbTMVi69X36OXA44Al0me5IM@z> On 01/31/2014 12:19 AM, Raghavendra K T wrote: > On 01/30/2014 09:08 PM, Waiman Long wrote: >> On 01/30/2014 03:55 AM, Raghavendra K T wrote: >>> On 01/28/2014 11:49 PM, Waiman Long wrote: > [...] > from kernel/bounds.c:9: >>> include/linux/log2.h: In function ‘__ilog2_u32’: >>> include/linux/log2.h:34:2: error: implicit declaration of function >>> ‘fls’ [-Werror=implicit-function-declaration] >>> include/linux/log2.h: In function ‘__ilog2_u64’: >>> include/linux/log2.h:42:2: error: implicit declaration of function >>> ‘fls64’ [-Werror=implicit-function-declaration] >>> include/linux/log2.h: In function ‘__roundup_pow_of_two’: >>> . >>> . >>> [trimmed] >>> >> >> The code will need to be compiled in either the latest linux tree as the >> patches have dependency on some new memory barrier that are in 3.14. >> Alternatively, you can compile with the latest tip tree. >> >> If you have already done that, please send me your config file so that I >> can reproduce the compilation error in my build environment. >> > > I did compile on latest linux tree which had barrier.txt. May be I 'll > recheck if I am missing something obvious. > > Here is .config attached An Update: The reason for failure was that I was compiling for guest. and CONFIG_PARAVIRT was enabled.