From: Richard Weinberger <richard@nod.at>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
viro@zeniv.linux.org.uk, vgupta@synopsys.com,
catalin.marinas@arm.com, will.deacon@arm.com,
hskinnemoen@gmail.com, egtvedt@samfundet.no, vapier@gentoo.org,
msalter@redhat.com, a-jacquiot@ti.com, starvik@axis.com,
jesper.nilsson@axis.com, dhowells@redhat.com,
rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com,
takata@linux-m32r.org, geert@linux-m68k.org,
james.hogan@imgtec.com, monstr@monstr.eu,
yasutake.koichi@jp.panasonic.com, ralf@linux-mips.org,
jonas@southpole.se, jejb@parisc-linux.org, deller@gmx.de,
benh@kernel.crashing.org, paulus@samba.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
liqin.linux@gmail.com, lennox.wu@gmail.com, cmetcalf@tilera.com,
gxt@mprc.pku.edu.cn, linux-xtensa@linux-xtensa.org,
akpm@linux-foundation.org, tj@kernel.org, hch@infradead.org
Subject: Re: [PATCH 28/44] Add translate_signal() helper
Date: Tue, 04 Mar 2014 21:43:10 +0100 [thread overview]
Message-ID: <53163ADE.8080905@nod.at> (raw)
In-Reply-To: <20140304184109.GB19393@redhat.com>
Am 04.03.2014 19:41, schrieb Oleg Nesterov:
> On 03/03, Richard Weinberger wrote:
>>
>> +static inline int translate_signal(int sig)
>> +{
>> + struct thread_info *info = current_thread_info();
>> +
>> + if (info->exec_domain
>
> Afaics it can't be NULL.
Good point. Will change.
>> && info->exec_domain->signal_invmap && sig < 32)
>> + return info->exec_domain->signal_invmap[sig];
>> +
>
> And why default_exec_domain has .signal_invmap = ident_map ?
> translate_signal-like code should check ->signal_invmap != NULL
> anyway.
>
> Off topic, but can't we kill exec_domain->signal_map ? it seems that
> it is unused.
>
> Hmm. And who actually uses exec_domain->handler() ?? asm-offsets.c,
> but I do not see any usage of TI_EXEC_DOMAIN.
>
> In short: I agree with this change but I am totally confused. To the
> point, I am not sure I even understand ->signal_invmap. I mean, it
> seems that only arthur_exec_domain has a non-ident map. Why, say,
> x86 does signr_convert() ? and only if CONFIG_X86_32? Is there any
> external module which does register_exec_domain(strange_invmap) ?
I remember a discussion with Al where he noted that register_exec_domain()
is currently only used by out of tree horrors. B-)
I'm sure we can rip it out of most archs. They seem to have it only because
they've copy&pasted it from i386.
Thanks,
//richard
next prev parent reply other threads:[~2014-03-04 20:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 23:59 [PATCH 23/44] unicore32: Use get_signal() signal_setup_done() Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 24/44] xtensa: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 25/44] Rip out get_signal_to_deliver() Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 26/44] tracehook_signal_handler: Remove sig, info, ka and regs Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 27/44] Clean up signal_delivered() Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 28/44] Add translate_signal() helper Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-04 18:41 ` Oleg Nesterov
2014-03-04 20:43 ` Richard Weinberger [this message]
2014-03-04 20:43 ` Richard Weinberger
2014-03-04 21:00 ` Christoph Hellwig
2014-03-04 21:00 ` Christoph Hellwig
2014-03-02 23:59 ` [PATCH 29/44] arc: Use translate_signal() Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-03 4:32 ` Vineet Gupta
2014-03-03 4:32 ` Vineet Gupta
2014-03-02 23:59 ` [PATCH 30/44] arm: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 31/44] arm64: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 32/44] blackfin: " Richard Weinberger
2014-03-02 23:59 ` [PATCH 33/44] frv: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 34/44] m32r: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
2014-03-02 23:59 ` [PATCH 35/44] m68k: " Richard Weinberger
2014-03-02 23:59 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53163ADE.8080905@nod.at \
--to=richard@nod.at \
--cc=a-jacquiot@ti.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=cmetcalf@tilera.com \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hskinnemoen@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=jejb@parisc-linux.org \
--cc=jesper.nilsson@axis.com \
--cc=jonas@southpole.se \
--cc=lennox.wu@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=liqin.linux@gmail.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rkuo@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
--cc=takata@linux-m32r.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vapier@gentoo.org \
--cc=vgupta@synopsys.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).