From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v7 06/11] pvqspinlock, x86: Allow unfair queue spinlock in a KVM guest Date: Thu, 20 Mar 2014 15:29:28 -0700 Message-ID: <532B6BC8.8010502@zytor.com> References: <1395260049-30839-1-git-send-email-Waiman.Long@hp.com> <1395260049-30839-7-git-send-email-Waiman.Long@hp.com> <532B6543.7050707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <532B6543.7050707@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Paolo Bonzini , Waiman Long , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , Peter Zijlstra Cc: Jeremy Fitzhardinge , Raghavendra K T , Gleb Natapov , Aswin Chandramouleeswaran , Andi Kleen , Michel Lespinasse , Boris Ostrovsky , linux-arch@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, "Paul E. McKenney" , Scott J Norton , Steven Rostedt , Chris Wright , Alok Kataria , virtualization@lists.linux-foundation.org, Chegu Vinod , Oleg Nesterov , linux-kernel@vger.kernel.org, David Vrabel , Andrew Morton List-Id: linux-arch.vger.kernel.org On 03/20/2014 03:01 PM, Paolo Bonzini wrote: > > No! Please do what I asked you to do. You are not handling Hyper-V or > VMWare. Just use X86_FEATURE_HYPERVISOR and it will cover all > hypervisors that actually follow Intel's guidelines. > And for those that don't, we should turn on X86_FEATURE_HYPERVISOR in the Linux enumeration code as we do for other features we detect independently. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from terminus.zytor.com ([198.137.202.10]:56685 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933903AbaCTWbQ (ORCPT ); Thu, 20 Mar 2014 18:31:16 -0400 Message-ID: <532B6BC8.8010502@zytor.com> Date: Thu, 20 Mar 2014 15:29:28 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [PATCH v7 06/11] pvqspinlock, x86: Allow unfair queue spinlock in a KVM guest References: <1395260049-30839-1-git-send-email-Waiman.Long@hp.com> <1395260049-30839-7-git-send-email-Waiman.Long@hp.com> <532B6543.7050707@redhat.com> In-Reply-To: <532B6543.7050707@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Paolo Bonzini , Waiman Long , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , Peter Zijlstra Cc: Jeremy Fitzhardinge , Raghavendra K T , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, Andi Kleen , Michel Lespinasse , Alok Kataria , linux-arch@vger.kernel.org, Gleb Natapov , x86@kernel.org, xen-devel@lists.xenproject.org, "Paul E. McKenney" , Scott J Norton , Rusty Russell , Steven Rostedt , Chris Wright , Oleg Nesterov , Boris Ostrovsky , Aswin Chandramouleeswaran , Chegu Vinod , linux-kernel@vger.kernel.org, David Vrabel , Andrew Morton Message-ID: <20140320222928.9I4jBARUrySajwplU_33mAd09J454DdL7wWadTEDm30@z> On 03/20/2014 03:01 PM, Paolo Bonzini wrote: > > No! Please do what I asked you to do. You are not handling Hyper-V or > VMWare. Just use X86_FEATURE_HYPERVISOR and it will cover all > hypervisors that actually follow Intel's guidelines. > And for those that don't, we should turn on X86_FEATURE_HYPERVISOR in the Linux enumeration code as we do for other features we detect independently. -hpa